add and use generic torch version comparator #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D56446353
Summary: # Context Before we would have an individual function for each version of pytorch we want to check for. Let's remove this in favor of a single universal function # This Diff Pass the version as a string instead and replaces old uses Reviewed By: galrotem Differential Revision: D56446382
JKSenthil
force-pushed
the
export-D56446382
branch
from
4166d97
to
0a76968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Before we would have an individual function for each version of pytorch we want to check for. Let's remove this in favor of a single universal function
This Diff
Pass the version as a string instead and replaces old uses
Differential Revision: D56446382