throughput logger #798
Open
throughput logger #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galrotem
force-pushed
the
export-D56496451
branch
2 times, most recently
from
b77c415
to
33fc106
Compare
Differential Revision: D56496429
Summary: Introduce throughput logger. Internal # Context The stack adds a throughput logger that can be used to log generic throughput per second, based on user config. This diff will add the throughput logger including logging per step. The next diff will add throughput on an epoch granularity. # This diff Adds throughput logger: 1. It uses the already collected iteration time and data wait time timers to get the step time. 2. It's slightly confusing but when `on_train_step_end` is called, the iteration time timer hasn't been populated yet, while the data wait time timer has been populated, hence there's a difference between the two when we are logging for (step-1). On the `on_train_end` both lists are fully populated so we can just use the last element safely. Reviewed By: JKSenthil Differential Revision: D56496451
galrotem
force-pushed
the
export-D56496451
branch
from
33fc106
to
da1e8d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce throughput logger.
Internal
Context
The stack adds a throughput logger that can be used to log generic throughput per second, based on user config.
This diff will add the throughput logger including logging per step. The next diff will add throughput on an epoch granularity.
This diff
Adds throughput logger:
on_train_step_endis called, the iteration time timer hasn't been populated yet, while the data wait time timer has been populated, hence there's a difference between the two when we are logging for (step-1). On theon_train_endboth lists are fully populated so we can just use the last element safely.Differential Revision: D56496451