Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacky fix to #5582 #5583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hacky fix to #5582 #5583

wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 21, 2024

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Update
9dfddaf 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Aug 21, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 6:45pm

ezyang added a commit that referenced this pull request Aug 21, 2024
@ezyang
Hacky fix to #5582
edfadd1 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 00eceb62f5cf9540193db3eb9a91c40f76a4bc24
ghstack-comment-id: 2302706756
Pull Request resolved: #5583
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2024
@ezyang
Copy link
Contributor Author

ezyang commented Aug 21, 2024

I don't know how to test this

@ezyang
Update
8196141 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 21, 2024
@ezyang
Hacky fix to #5582
f87a4b1 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 71aacb1e2a2df6a5bf21d826d02dcae9626ba3b8
ghstack-comment-id: 2302706756
Pull Request resolved: #5583
@ezyang ezyang requested a review from huydhn August 21, 2024 18:45
@malfet
Copy link
Contributor

malfet commented Sep 3, 2024

I don't think it'll fix it, you'll need to sys.stdout.flush() but also it's not fixable until one tweaks runner to send data more frequently...

@ezyang
Copy link
Contributor Author

ezyang commented Sep 4, 2024

In my ideal world, we wouldn't have a tailer here at all......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn Awaiting requested review from huydhn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezyang @malfet @facebook-github-bot