Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOMERG, WIP] Add TensorMap in cpp #105

Draft
wants to merge 84 commits into
base: main
Choose a base branch
from
Draft

[NOMERG, WIP] Add TensorMap in cpp #105

wants to merge 84 commits into from

Commits on Dec 5, 2022

  1. [TensorDict] Add cpp tensormap header file

    @najielhachem
    najielhachem committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    12f05c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Add first version of tensormap

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d5db9dc View commit details
    Browse the repository at this point in the history

  2. Add extension build to setup.py

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    65c014d View commit details
    Browse the repository at this point in the history

  3. Fix setup.py

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d92bde8 View commit details
    Browse the repository at this point in the history

  4. ignore build folder

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    54891a1 View commit details
    Browse the repository at this point in the history

  5. use pybind tuple instead of std tuple

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6af4d5e View commit details
    Browse the repository at this point in the history

  6. use vector instead of tuple

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c6de1e5 View commit details
    Browse the repository at this point in the history

  7. Add SetRecursive

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1fb40fd View commit details
    Browse the repository at this point in the history

  8. Ignore .Idea project

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    e412b37 View commit details
    Browse the repository at this point in the history

  9. Replace SetRecursive by GetRecursive to return pointer to map

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3e8b0c5 View commit details
    Browse the repository at this point in the history

  10. Implement get and set with tuple in TensorMap

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    89ae1ee View commit details
    Browse the repository at this point in the history

  11. Fix pass by reference in recursive call

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    db3c628 View commit details
    Browse the repository at this point in the history

  12. Pybind add binding for TensorMap class

    @najielhachem
    najielhachem committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1953349 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. replace stdexcpt with exception library

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    54b416b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature_tensormap

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    348aa70 View commit details
    Browse the repository at this point in the history

  3. small amend

    @vmoens
    vmoens committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    cd20aab View commit details
    Browse the repository at this point in the history

  4. Use cpp 17

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f40f41b View commit details
    Browse the repository at this point in the history

  5. Remove overloads from binding

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    2640455 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'nagielhachem/feature_tensormap' into fe… 

    …ature_tensormap

# Conflicts:
#	setup.py
#	tensordict/cpp/pybind.cpp
    @vmoens
    vmoens committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c0d54d0 View commit details
    Browse the repository at this point in the history

  7. Add first test to TensorMap

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    273cd96 View commit details
    Browse the repository at this point in the history

  8. Pass all arguments by reference

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    2442208 View commit details
    Browse the repository at this point in the history

  9. Store pointers of tensor and class in internal map

    @najielhachem
    najielhachem committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4a68032 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Merge remote-tracking branch 'nagielhachem/feature_tensormap' into fe… 

    …ature_tensormap

# Conflicts:
#	tensordict/cpp/tensormap.cpp
    @vmoens
    vmoens committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1db0e72 View commit details
    Browse the repository at this point in the history

  2. small amend

    @vmoens
    vmoens committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e3a34ae View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Comment code

    @najielhachem
    najielhachem committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7dab00e View commit details
    Browse the repository at this point in the history

  2. Simple tensor map by reference

    @najielhachem
    najielhachem committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    85ffd04 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Fix usage of internal map

    @najielhachem
    najielhachem committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6f5467b View commit details
    Browse the repository at this point in the history

  2. Use variant in map

    @najielhachem
    najielhachem committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    478969f View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Use allocated memory to store map

    @najielhachem
    najielhachem committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3c56d35 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Use shared_ptr instead of normal ptr

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7f0caeb View commit details
    Browse the repository at this point in the history

  2. Overrite tensormap operators

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    d3e4982 View commit details
    Browse the repository at this point in the history

  3. Use shared_ptr to manage TensorMap in pybind

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c615e08 View commit details
    Browse the repository at this point in the history

  4. Add const to methods

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    e08268e View commit details
    Browse the repository at this point in the history

  5. typedef map

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ae31025 View commit details
    Browse the repository at this point in the history

  6. Implement GetRecursive with forcePath and pointers

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9f5f646 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'nagielhachem/feature_tensormap' into fe… 

    …ature_tensormap

# Conflicts:
#	tensordict/cpp/pybind.cpp
    @vmoens
    vmoens committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    1c8f098 View commit details
    Browse the repository at this point in the history

  8. Add SetTensorMapAtPath

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    53132d5 View commit details
    Browse the repository at this point in the history

  9. Refactor GetRecursive into two methods

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c523e5a View commit details
    Browse the repository at this point in the history

  10. Add PlayGround.py

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b08c0b9 View commit details
    Browse the repository at this point in the history

  11. Add first implementation of keys

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    0753276 View commit details
    Browse the repository at this point in the history

  12. Replace Vector by Tuple in GetAtPath

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    22417e6 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'feature_tensormap' of https://github.com/nagielhachem/t… 

    …ensordict into feature_tensormap
    @vmoens
    vmoens committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7d4206d View commit details
    Browse the repository at this point in the history

  14. Use python methods

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c18145d View commit details
    Browse the repository at this point in the history

  15. Use tuples in set

    @najielhachem
    najielhachem committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9be8e76 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'feature_tensormap' of https://github.com/nagielhachem/t… 

    …ensordict into feature_tensormap
    @vmoens
    vmoens committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7f84936 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Fix GetKeys

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    11a469b View commit details
    Browse the repository at this point in the history

  2. Add init_extension to setup

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    07bc770 View commit details
    Browse the repository at this point in the history

  3. Change module directory and name

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    93ea8f2 View commit details
    Browse the repository at this point in the history

  4. Better import for TensorMap

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    94a8596 View commit details
    Browse the repository at this point in the history

  5. Use __setitem__ and __getitem__

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    f7fc3bc View commit details
    Browse the repository at this point in the history

  6. Add keys test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    61a47f1 View commit details
    Browse the repository at this point in the history

  7. [Test] Add test_simple_set_tensor

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    7e0e8e2 View commit details
    Browse the repository at this point in the history

  8. [Test] Add simple set map ref test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    46393cd View commit details
    Browse the repository at this point in the history

  9. [Test] Add nested set test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    e59b629 View commit details
    Browse the repository at this point in the history

  10. [Test] Add tensormap nested overrite test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    51c3f5e View commit details
    Browse the repository at this point in the history

  11. [Test] Add get_keys test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ea6563c View commit details
    Browse the repository at this point in the history

  12. [Test] Add in keys test

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    3aca32d View commit details
    Browse the repository at this point in the history

  13. Delete playground

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    32170b2 View commit details
    Browse the repository at this point in the history

  14. Reorganize tensormap.h

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    eaa769d View commit details
    Browse the repository at this point in the history

  15. Add default arguments to get_keys()

    @najielhachem
    najielhachem committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    d6a55ba View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'nagielhachem/feature_tensormap' into fe… 

    …ature_tensormap

# Conflicts:
#	setup.py
#	tensordict/__init__.py
    @vmoens
    vmoens committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1092cfa View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. amend

    @vmoens
    vmoens committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    cf4ed19 View commit details
    Browse the repository at this point in the history

  2. Revert "amend" 

    This reverts commit cf4ed19.
    @vmoens
    vmoens committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    6285ed5 View commit details
    Browse the repository at this point in the history

  3. [Test] Skip failing tests

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d69f391 View commit details
    Browse the repository at this point in the history

  4. Use variant type as key

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    040684c View commit details
    Browse the repository at this point in the history

  5. [TensorMap] return str as key if on level 0

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    65b9fce View commit details
    Browse the repository at this point in the history

  6. [TensorMap] implement keys on first level

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    8bc3b4c View commit details
    Browse the repository at this point in the history

  7. [TensorMap] Implement leavesonly for firstlevel in keys

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    41c69ef View commit details
    Browse the repository at this point in the history

  8. [TensorMap] Refactor GetKeys methods

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    92e277d View commit details
    Browse the repository at this point in the history

  9. [Test] Fix set comparision

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d895ee4 View commit details
    Browse the repository at this point in the history

  10. [TensorMap] Implement keys with nested all nodes

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    00dcd25 View commit details
    Browse the repository at this point in the history

  11. [Test] Fix in keys test

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    c6ff2fa View commit details
    Browse the repository at this point in the history

  12. [TensorMap] Add batchsize to constructor

    @najielhachem
    najielhachem committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    9ef8a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. [Test] Add test for batchsize constraint

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5f6c90d View commit details
    Browse the repository at this point in the history

  2. [TensorMap] Add batchsize constraint on set tensor

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    bb076ce View commit details
    Browse the repository at this point in the history

  3. [TensorMap] use c10::IntArrayRef instead of vector

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    4d823c9 View commit details
    Browse the repository at this point in the history

  4. Implement TensorMap batchsize check for map set

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    263d6d4 View commit details
    Browse the repository at this point in the history

  5. [TensorMap] Use TensorMap* instead of map* in recursive calls

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ef2dfa7 View commit details
    Browse the repository at this point in the history

  6. [TensorMap] Merge SetTensor and SetMap methods

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f95683f View commit details
    Browse the repository at this point in the history

  7. [Test] Add unit test for batch constraint on nested dict

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    1712a6a View commit details
    Browse the repository at this point in the history

  8. [TensorMap] Implement nested dict batch constraint

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d700af6 View commit details
    Browse the repository at this point in the history

  9. [TensorMap] Fix batchSize constraint case with forced set map

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    49b94e2 View commit details
    Browse the repository at this point in the history

  10. [TensorMap] Clean code

    @najielhachem
    najielhachem committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    20bb0a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Merge remote-tracking branch 'upstream/main' into feature_tensormap

    @najielhachem
    najielhachem committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6f6ca6d View commit details
    Browse the repository at this point in the history