Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Rewrite check_binary_symbols as Python script #1978

Merged
merged 5 commits into from
Sep 4, 2024
Merged

[BE] Rewrite check_binary_symbols as Python script #1978

merged 5 commits into from
Sep 4, 2024

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 4, 2024 •
edited
Loading

This makes code a bit more readable and make verification run so much faster as we can cache the results on python side and also run matching concurrently using ThreadPoolExecutor

Before the change

% DESIRED_PYTHON=3.10 time ./check_binary.sh 
...
250.58user 39.22system 3:05.68elapsed 156%CPU (0avgtext+0avgdata 962164maxresident)k

After the change

% DESIRED_PYTHON=3.10 time ./check_binary.sh 
...
111.73user 12.29system 0:46.70elapsed 265%CPU (0avgtext+0avgdata 938088maxresident)

@malfet
[BE] Rewrite check_binary_symbols as Python script
098ded5 
This makes code a bit more readable and make verification run so much faster as we can cache the results on python side and also run matching concurrently
@malfet malfet merged commit 4042500 into main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malfet @facebook-github-bot