Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codemod][PSS] Upgrade fbcode/pytorch to Python Scientific Stack 2 #3845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorsugak
Copy link
Contributor

Differential Revision: D64008689

@igorsugak igorsugak requested a review from a team as a code owner October 18, 2024 03:49
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3845

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 12 Unrelated Failures

As of commit 32abc8d with merge base 79047bf (image):

NEW FAILURES - The following jobs have failed:

  • Integration Test / build (3.8) (gh)
    subprocess.CalledProcessError: Command '['cmake', '/home/runner/work/audio/audio', '-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_PREFIX_PATH=/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/torch/share/cmake', '-DCMAKE_INSTALL_PREFIX=/home/runner/work/audio/audio/build/lib.linux-x86_64-cpython-38/', '-DCMAKE_VERBOSE_MAKEFILE=ON', '-DPython_INCLUDE_DIR=/opt/hostedtoolcache/Python/3.8.18/x64/include/python3.8', '-DBUILD_CPP_TEST=OFF', '-DBUILD_SOX:BOOL=ON', '-DBUILD_RIR:BOOL=ON', '-DBUILD_RNNT:BOOL=ON', '-DBUILD_ALIGN:BOOL=ON', '-DBUILD_CUDA_CTC_DECODER:BOOL=ON', '-DBUILD_TORCHAUDIO_PYTHON_EXTENSION:BOOL=ON', '-DBUILD_TORIO_PYTHON_EXTENSION:BOOL=ON', '-DUSE_ROCM:BOOL=OFF', '-DUSE_CUDA:BOOL=ON', '-DUSE_OPENMP:BOOL=ON', '-DUSE_FFMPEG:BOOL=ON', '-GNinja']' returned non-zero exit status 1.
  • Unit-tests on Linux GPU / tests (3.10, 11.8) / linux-job (gh)
    RuntimeError: Command docker exec -t 078f067c6e4ab7131b4cf9a96508f552c6c387fee03c4e6f823fd180fdddaf92 /exec failed with exit code 2
  • Unit-tests on Linux GPU / tests (3.8, 11.8) / linux-job (gh)
    RuntimeError: Command docker exec -t e27fa9dea464df6a53bba3b3a477abdfde142ea10276231cc9335e5aca61ae2c /exec failed with exit code 2
  • Unit-tests on Linux GPU / tests (3.9, 11.8) / linux-job (gh)
    RuntimeError: Command docker exec -t 0bfdcd06eda30762393eb8b4236e7e062c2d193203aa86a142c358488914fbde /exec failed with exit code 2

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary: Pull Request resolved: pytorch/audio#3845

Differential Revision: D64008689
igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/botorch that referenced this pull request Oct 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

igorsugak added a commit to igorsugak/audio that referenced this pull request Oct 18, 2024
…ch#3845)

Summary:
X-link: pytorch/opacus#680
X-link: pytorch/captum#1387
X-link: pytorch/botorch#2584

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/botorch that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/audio#3846

X-link: pytorch/opacus#680
X-link: pytorch/captum#1387
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/audio#3846

X-link: pytorch/opacus#680
X-link: pytorch/botorch#2584
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/captum#1389

X-link: pytorch/botorch#2586

X-link: pytorch/audio#3846

X-link: pytorch/captum#1387
X-link: pytorch/botorch#2584
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
facebook-github-bot pushed a commit that referenced this pull request Oct 19, 2024
Differential Revision: D64619891

Pull Request resolved: #3846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants