Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 667: Mark as Final #3942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 3, 2024

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3781.

@markshannon @gaogaotiantian:


📚 Documentation preview 📚: https://pep-previews--3942.org.readthedocs.build/

@hugovk hugovk mentioned this pull request Sep 3, 2024
6 tasks
@ncoghlan
Copy link
Contributor

ncoghlan commented Sep 4, 2024

#3845 is still open, along with the corresponding SC ticket at python/steering-council#245 so I don't believe it's quite there yet (specifically missing the second point in the checklist).

For the canonical docs, there are a few relevant canonical links:

@hugovk
Copy link
Member Author

hugovk commented Sep 4, 2024

Thanks, let's move this to draft until it's ready.

@hugovk hugovk marked this pull request as draft September 4, 2024 13:06
@ncoghlan
Copy link
Contributor

#3845 has been approved and merged, so I think this is genuinely Final now.

@ncoghlan ncoghlan marked this pull request as ready for review October 21, 2024 17:55
Type: Standards Track
Created: 30-Jul-2021
Python-Version: 3.13
Post-History: 20-Aug-2021, 22-Feb-2024
Resolution: https://discuss.python.org/t/pep-667-consistent-views-of-namespaces/46631/25

.. canonical-doc:: :external+py3.13:func:`locals`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the PEP status resolved, that just leaves the question of whether or not we should expand on the canonical docs reference (since the PEP affected multiple things that are documented in different places).

@@ -3,13 +3,15 @@ Title: Consistent views of namespaces
Author: Mark Shannon <mark@hotpy.org>,
Tian Gao <gaogaotiantian@hotmail.com>
Discussions-To: https://discuss.python.org/t/46631
Status: Accepted
Status: Final
Type: Standards Track
Created: 30-Jul-2021
Python-Version: 3.13
Post-History: 20-Aug-2021, 22-Feb-2024
Resolution: https://discuss.python.org/t/pep-667-consistent-views-of-namespaces/46631/25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here:

Suggested change
Resolution: https://discuss.python.org/t/pep-667-consistent-views-of-namespaces/46631/25
Resolution: `25-Apr-2024 <https://discuss.python.org/t/pep-667-consistent-views-of-namespaces/46631/25>`__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants