Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Don't close stream passed to PdfWriter.write() #2909

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

BUG: Don't close stream passed to PdfWriter.write() #2909

wants to merge 5 commits into from

Commits on Oct 18, 2024

  1. BUG: Don't close stream passed to PdfWriter.write()

    @alexaryn
    alexaryn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1d9a52c View commit details
    Browse the repository at this point in the history

  2. mypy

    @alexaryn
    alexaryn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5568450 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Improvements based on code review comments.

    @alexaryn
    alexaryn committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a905bac View commit details
    Browse the repository at this point in the history

  2. Make test work with Python 3.8.

    @alexaryn
    alexaryn committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    dafbafc View commit details
    Browse the repository at this point in the history

  3. Use tmp_path to avoid needing to unlink.

    @alexaryn
    alexaryn committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3d6b7dc View commit details
    Browse the repository at this point in the history