Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes messageObj for meta and reaction message type #645

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Aug 16, 2023

No description provided.

@github-actions
Copy link

File: packages/restapi/package.json

  • Line 33: missing closing brace '}' after "peerDependencies" object.
  • Line 35: missing comma after "peerDependencies" object.
  • Line 36: missing closing brace '}' after "dependencies" object.
  • Line 38: missing comma after "dependencies" object.
  • Line 40: missing closing brace '}' after "scripts" object.
  • Line 42: missing comma after "scripts" object.
  • Line 44: missing closing brace '}' after "devDependencies" object.
  • Line 46: missing comma after "devDependencies" object.

File: packages/restapi/src/lib/chat/helpers/payloadHelper.ts

  • Line 18: missing closing brace '}' after "IApproveRequestPayload" interface declaration.
  • Line 34: missing closing brace '}' after "ICreateGroupRequestPayload" interface declaration.
  • Line 64: missing closing brace '}' after "ISendMessagePayload" interface declaration.

File: packages/restapi/src/lib/chat/send.ts

  • Line 111: missing closing brace '}' after "apiEndpoint" variable assignment.

File: packages/restapi/src/lib/space/Space.ts

  • Line 48: missing closing brace '}' after "initSpaceData" object.

File: packages/restapi/src/lib/space/broadcastRaisedHand.ts

  • Line 28: missing closing brace '}' after "broadcastRaisedHandType" object.
  • Line 38: missing closing brace '}' after await statement.
  • Line 47: missing closing brace '}' after call to setSpaceSpecificData function.

All looks good.

File: packages/restapi/src/lib/types/index.ts

All looks good.

File: packages/restapi/src/lib/types/messageObjectTypes.ts

All looks good.

File: packages/restapi/src/lib/validations/messageObject.ts

All looks good.

File: packages/restapi/tests/lib/chat/send.test.ts

All looks good.

File: packages/restapi/yarn.lock

All looks good.

@Aman035 Aman035 linked an issue Aug 17, 2023 that may be closed by this pull request
@github-actions
Copy link

File: packages/restapi/package.json

{
"name": "@pushprotocol/restapi",
"version": "1.4.11",
"type": "commonjs",
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"peerDependencies": {
"ethers": "^5.6.8"
},
"dependencies": {
"@ambire/signature-validator": "^1.3.1",
"@livepeer/webrtmp-sdk": "^0.2.3",
"@metamask/eth-sig-util": "^5.0.2",
"buffer": "^6.0.3",
"crypto-js": "^4.1.1",
"immer": "^10.0.2",
"joi": "^17.9.2",
"livepeer": "^2.5.8",
"openpgp": "^5.5.0",
"simple-peer": "^9.11.1",
"video-stream-merger": "^4.0.1"
},
"scripts": {
"test": "TS_NODE_PROJECT='./tsconfig.mocha.json' NODE_OPTIONS='--loader ts-node/esm' mocha -r ts-node/register 'tests/**/*.test.ts' --timeout 120000 --require tests/root.ts --serial"
},
"devDependencies": {
"@types/chai": "^4.3.4",
"@types/chai-as-promised": "^7.1.5",
"@types/crypto-js": "^4.1.1",
"@types/mocha": "^10.0.1",
"chai": "^4.3.7",
"chai-as-promised": "^7.1.1",
"mocha": "^10.2.0",
"mocha-typescript": "^1.1.17",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
}
}

All looks good.

Copy link
Contributor

@madhur-push madhur-push left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aman035 Aman035 merged commit 4077049 into main Aug 23, 2023
1 check passed
@Aman035 Aman035 deleted the remove-meta-property-from-messageObj branch September 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Meta property from Reaction and Meta messageTypes
3 participants