Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added profile picture in the message bubble for group chat #617

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

KlausMikhaelson
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/MessageBubbles.tsx

  1. On line 21, there is a missing closing parenthesis after the env: ENV.STAGING argument in the await PUSHAPI.chat.decryptPGPKey function.

  2. On line 28, there is a missing closing parenthesis after the pgpDecryptedPvtKey ? pgpDecryptedPvtKey : undefined argument in await PUSHAPI.chat.history function.

  3. On line 29, setMessage(chatHistory) is missing a closing parenthesis in the await PUSHAPI.chat.history function.

  4. On line 40, setMessage(chatHistory) is missing a closing parenthesis after the const chatHistory = await PUSHAPI.chat.history function.

  5. On line 52, message.map should have a unique key attribute for each MessageBubble component.

  6. It's recommended to specify the array dependency for the useEffect hook on line 44 to avoid unnecessary re-fetching of messages.

  7. The file seems to be missing the import statements for the MessageBubble component and IMessagePayload type.

File: packages/uiweb/src/lib/components/chat/MessageBubble/MessageBubble.tsx

  1. On line 38, there is a missing closing parenthesis after the color="#62626A" attribute value in the Span component.

  2. The component SenderMessageProfile on line 62 doesn't return anything. It should return the Section component.

  3. The component MessageCard on line 100 is missing a closing parenthesis after the justifyContent="start" attribute value in the root Section component.

  4. On line 204, there is a missing closing parenthesis after the bottom="6px" attribute value in the Span component.

  5. On line 243, there is a missing closing /> tag for the Image component.

  6. There is a missing closing parenthesis on line 246 after the width="20px" attribute value in the Image component.

  7. On line 258, the closing </Section> tag is misplaced. It should be after the closing </ImageCard> tag.

  8. The component GIFCard on line 275 is missing a closing parenthesis after the src={chat.messageContent} attribute in the Image component.

  9. The TwitterCard component on line 305 is missing a closing parenthesis after the chat={chat} attribute in the TwitterCard component.

File: packages/uiweb/src/lib/helpers/chat/localStorage.ts

  1. On line 18, the setData function is missing a closing parenthesis after the value: IFeeds; argument.

  2. On line 23, the getData function is missing a closing parenthesis after the null argument.

  3. On line 53, the getPfp function is missing a closing parenthesis after the env: ENV; argument.

  4. On line 63, there is a missing closing parenthesis after the console.log(err.message) statement.

  5. On line 68, the fetchData function is missing a closing parenthesis after the closing curly brace of the function body.

  6. On line 71, the pfp variable is assigned the value returned by localStorage.getItem(account). It should be parsed as JSON using JSON.parse(pfp).

  7. On line 77, there is a missing closing parenthesis after the return fetchData() statement.

  8. On line 81, there is a missing closing parenthesis after the return pfp statement.

  9. On line 89, there is a missing closing parenthesis after the value argument in the setPfp function.

  10. On line 94, there is a missing closing parenthesis after the value argument in the localStorage.setItem(account, value) statement.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/MessageBubbles.tsx

  1. In line 17, there is a missing closing brace "}" for the await PUSHAPI.chat.decryptPGPKey() function call.

  2. In line 21, the variable name should be conversationHash instead of ConversationHash.

  3. In line 23, there is a missing closing parenthesis ")" for the setMessage() function call.

  4. In line 28, there is a missing closing parenthesis ")" for the setMessage(chatHistory) function call.

  5. In line 34, there is a missing closing parenthesis ")" for the fetchMessage() function call.

File: packages/uiweb/src/lib/components/chat/MessageBubble/MessageBubble.tsx

  1. In line 27, there is a missing closing parenthesis ")" for the useEffect() function call.

  2. In line 37, there is a missing opening brace "{" for the Section component.

  3. In line 41, there is a missing opening brace "{" for the second Section component.

  4. In line 68, there is a missing closing parenthesis ")" for the time variable assignment.

  5. In line 93, there is a missing opening brace "{" for the Section component.

  6. In line 101, there is a missing opening brace "{" for the Span component.

  7. In line 106, there is a missing closing parenthesis ")" for the formatFileSize(size) function call.

  8. In line 113, there is a missing closing parenthesis ")" for the FileDownloadIconAnchor component.

  9. In line 145, there is a missing closing parenthesis ")" for the Section component.

  10. In line 199, there is a missing closing parenthesis ")" for the Section component.

  11. In line 201, there is a missing opening brace "{" for the Span component.

  12. In line 271, there is a missing opening brace "{" for the TwitterCard component.

  13. In line 317, there is a missing opening brace "{" for the MessageBubble component.

File: packages/uiweb/src/lib/helpers/chat/localStorage.ts

  1. In line 15, there is a missing opening brace "{" for the setData() function.

  2. In line 19, there is a missing closing parenthesis ")" for the setData() function call.

  3. In line 23, there is a missing opening brace "{" for the getData() function.

  4. In line 28, there is a missing closing brace "}" for the getData() function.

  5. In line 32, there is a missing opening brace "{" for the getPfp() function.

  6. In line 43, there is a missing closing brace "}" for the fetchData() function.

  7. In line 54, there is a missing opening brace "{" for the pfp variable.

  8. In line 60, there is a missing closing parenthesis ")" for the return fetchData() statement.

  9. In line 80, there is a missing opening brace "{" for the setPfp() function.

  10. In line 97, there is a missing closing parenthesis ")" for the localStorage.setItem() function call.

All looks good.

@KlausMikhaelson KlausMikhaelson merged commit 90c4421 into feat/chat-components Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants