Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/spaces #591

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Feat/spaces #591

merged 13 commits into from
Jul 31, 2023

Conversation

0xNilesh
Copy link
Member

No description provided.

0xNilesh and others added 13 commits July 24, 2023 19:32
…tor/space-socket

refactor: added space socket instance in context itself
…ocket-connection-multiple-instances

fix: resolved socket multiple instances getting created
* fix: fix members modal, add requestMic

* fix: add useEffect for raiseRequest

* feat: add acc rej UI

* feat: add invite to listener

* fix: rm raisedhand export

* fix: fix members modal, add requestMic

* fix: add useEffect for raiseRequest

* feat: add acc rej UI

* feat: add invite to listener

* fix: rm raisedhand export

* feat(spaces): add functions to handle meta messages

* fix(spaces): bug fix in raise hand handler

* feat: added listener mgmt UI

* fix(spaces): display roles from live space data

---------

Co-authored-by: Madhur Gupta <madhur@push.org>
* feat: raised hand

* fix: accept fix

* fix(spaces): fix hand raised

* fix: add requests icon

* fix(spaces): remove UI peices

---------

Co-authored-by: Madhur Gupta <madhur@push.org>
* fix: fix width issue

* feat: eslint fix

* chore: eslint
@github-actions
Copy link

File: packages/uiweb/src/lib/components/space/SpaceFeed/SpaceFeed.tsx

  1. There is a missing closing bracket '}' at the end of the file, after the return statement.

  2. There is a typo in the import statement of the Spinner component. It should be import { Spinner } from '../reusable/Spinner';.

  3. The TabsValues type and FilterEnums enum definitions should be moved outside of the ISpaceFeedProps interface definition.

  4. In the useSpaceRequests hook import statement, the useSpaceRequests function is missing parentheses at the end.

  5. In the handleFilterData function, the third case where filterTab === FilterEnums.Scheduled is missing a return statement.

  6. In the handleMySpacesFilter function, the two cases where selectedFeedTab === FeedTabs.HostedByYou and selectedFeedTab === FeedTabs.ForYou are missing a filter method to filter the spacesList.

  7. The handleClick function is missing a closing parentheses ')' at the end of the return statement.

  8. In the incrementSpacePage function, there is an unnecessary console.log statement.

File: packages/uiweb/src/lib/components/space/SpaceWidget/ScheduledWidgetContent.tsx

  1. In the handleShareAction function, the cases for ShareOptions.Lenster and ShareOptions.Copy are missing a break statement at the end.

  2. The getShareOptionDetails function is missing a return statement at the end.

  3. The startSpace function is calling itself recursively without any exit condition.

File: packages/uiweb/src/lib/components/space/SpaceWidget/helpers/utils.ts

  1. The isLiveSpace function is missing a return statement at the end.

File: packages/uiweb/src/lib/components/space/helpers/account.ts

  1. The isNftProfile function is missing a closing parentheses ')' at the end of the return statement.

  2. The spaceChainId function is missing a closing parentheses ')' at the end of the if statement.

  3. The isAccountsEqual function is missing a closing parentheses ')' at the end of the if statement on the second line.

File: packages/uiweb/src/lib/dataProviders/SpaceComponentsWrapper.tsx

  1. The import statement for the React module is missing.

File: packages/uiweb/src/lib/hooks/space/usePushSpaceSocket.tsx

  1. The usePushSpaceSocket function is missing a closing parentheses ')' at the end of the react import statement.

  2. The addSocketEvents function is missing a closing parentheses ')' at the end of the arrow function for the pushSpaceSocket?.on(EVENTS.DISCONNECT, ...) event.

  3. The pushSpaceSocket?.on('SPACES_MESSAGES', ...) event is commented out and should be uncommented.

  4. The pushSpaceSocket?.on(EVENTS.CHAT_RECEIVED_MESSAGE, ...) event is commented out and should be uncommented.

  5. The spacesObjectRef?.current?.onReceiveMetaMessage?.({...}) method call inside the pushSpaceSocket?.on(EVENTS.CHAT_RECEIVED_MESSAGE, ...) event is commented out and should be uncommented.

  6. The pushSpaceSocket?.on('SPACES', ...) event is missing a closing parentheses ')' at the end of the arrow function.

  7. The const updatedRequests declaration inside the pushSpaceSocket?.on('SPACES', ...) event is missing a closing parentheses ')' at the end of the PushAPI.space.space({...}) method call.

@mohammeds1992 mohammeds1992 merged commit aa5704c into main Jul 31, 2023
1 check passed
@0xNilesh 0xNilesh deleted the feat/spaces branch August 18, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants