Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the livepeer API key #590

Merged
merged 11 commits into from
Jul 28, 2023
Merged

Replace the livepeer API key #590

merged 11 commits into from
Jul 28, 2023

Conversation

madhur-push
Copy link
Contributor

No description provided.

0xNilesh and others added 11 commits July 24, 2023 19:32
…tor/space-socket

refactor: added space socket instance in context itself
…ocket-connection-multiple-instances

fix: resolved socket multiple instances getting created
* fix: fix members modal, add requestMic

* fix: add useEffect for raiseRequest

* feat: add acc rej UI

* feat: add invite to listener

* fix: rm raisedhand export

* fix: fix members modal, add requestMic

* fix: add useEffect for raiseRequest

* feat: add acc rej UI

* feat: add invite to listener

* fix: rm raisedhand export

* feat(spaces): add functions to handle meta messages

* fix(spaces): bug fix in raise hand handler

* feat: added listener mgmt UI

* fix(spaces): display roles from live space data

---------

Co-authored-by: Madhur Gupta <madhur@push.org>
* feat: raised hand

* fix: accept fix

* fix(spaces): fix hand raised

* fix: add requests icon

* fix(spaces): remove UI peices

---------

Co-authored-by: Madhur Gupta <madhur@push.org>
* fix: fix width issue

* feat: eslint fix

* chore: eslint
@github-actions
Copy link

File: packages/uiweb/src/lib/components/space/SpaceWidget/ScheduledWidgetContent.tsx

  1. In the handleShareAction function, there is a missing break statement after the handleShareLenster() call. It should be added after that line to prevent fall-through to the default case.

  2. In the getShareOptionDetails function, the assignment of icon and alt variables should be inside separate conditions of the shareOption switch statement. Currently, all the assignments are happening one after the other, resulting in only the last assignment being effective.

  3. The startSpace function inside the useEffect hook is missing a closing bracket at the end.

  4. The value passed to the setSpaceStatusState function is not checked for existence before calling it. This could potentially cause an error if setSpaceStatusState is not defined. It is better to conditionally call it only if it exists.

File: packages/uiweb/src/lib/dataProviders/SpaceComponentsWrapper.tsx

  1. In the useSpaceNotificationSocket function call, there is an empty object literal as the argument. This should be removed if there are no specific options to be passed.

File: packages/uiweb/src/lib/dataProviders/SpaceDataProvider.tsx

  1. The useState hook declaration for popularSpaces is incomplete. It should be completed with an initial value assignment.

  2. The useState hook declaration for spaceRequests is incomplete. It should be completed with an initial value assignment.

  3. The useState hook declaration for pushSpaceSocket is incomplete. It should be completed with an initial value assignment.

  4. The isJoined variable is missing a closing parenthesis at the end.

  5. The createReactClient function call is missing a closing parenthesis at the end.

  6. The commented out isLive variable is not necessary and can be removed.

  7. The setSpaceInfoItem function is missing a closing parenthesis at the end.

  8. The setSpeakerDataItem function is missing a closing parenthesis at the end.

  9. The initSpaceObject function is missing a closing parenthesis at the end.

  10. The acceptSpaceRequest function is missing a closing parenthesis at the end.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 5185edb into main Jul 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants