Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment #577

Merged
merged 131 commits into from
Jul 22, 2023
Merged

Deployment #577

merged 131 commits into from
Jul 22, 2023

Conversation

mohammeds1992
Copy link
Collaborator

No description provided.

@github-actions
Copy link

In the file packages/examples/sdk-backend-node/src/spaces/index.ts:

  • Line 9: There is a missing closing parentheses after the argument of signerSecondAccount.
  • Line 10: There is a missing closing brace } for the PushAPI.user.create function call.
  • Line 11: There is a missing opening brace { for the console.log statement.
  • Line 12: There is a missing closing parentheses ) for the console.log statement.
  • Line 19: There is a missing closing parentheses `

@github-actions
Copy link

File: packages/restapi/README.md

  • In the section "Index", the link for "restapi" is unnecessary as it points to the current README.
  • In the section "How to use in your app?", the formatting for the subheadings under "About generating the 'signer' object for different platforms" is incorrect. They should be indented with four spaces each.
  • In the section "How to use in your app?", the code block for installing the package is missing closing backticks.
  • In the section "How to use in your app?", the code block for importing the SDK is missing closing backticks.
  • In the section "About generating the 'signer' object for different platforms", the first code block for SERVER-SIDE code is missing closing backticks.
  • In the section "About generating the 'signer' object for different platforms", the second code block for FRONT-END code is missing closing backticks.

File: packages/restapi/package.json

  • The "peerDependencies" object is missing a closing curly brace.
  • The "dependencies" object is missing a closing curly brace.
  • The "scripts" object is missing a closing curly brace.
  • The "devDependencies" object is missing a closing curly brace.

All looks good.

Copy link
Contributor

@madhur-push madhur-push left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohammeds1992 mohammeds1992 merged commit 74d71f2 into main Jul 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants