Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(alpha): merge branch 'alpha' into feat/spaces-implementation #564

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

madhur-push
Copy link
Contributor

No description provided.

@github-actions
Copy link

File: packages/demoreact/src/app/ChatWidgetTest.tsx

  1. In line 17, the variable name pvtkey should be pvtKey for consistency.
  2. In lines 23-32, the code can be simplified by removing the if condition and directly assigning the response to pvtKey variable.
  3. In line 27, response should be declared with the const keyword for consistency.
  4. In line 30, the closing parenthesis for the setPvtKey function should be on a new line for better readability.
  5. In line 40, the activeTab prop is commented out. Please check if it is necessary and uncomment it if required.
  6. In line 44, the activeChat prop should be enclosed in curly braces {} for JSX interpolation.

File: packages/demoreact/src/app/NotificationsTest.tsx

  1. In line 25, there is a missing closing curly brace } for the Header component.
  2. In line 27, there is a missing closing curly brace } for the ThemeSelector component.
  3. In lines 35-59, there is a commented out code block related to customTheme. Please check if it is necessary and remove the comments if not needed.
  4. In line 60, there is a missing opening curly brace { for the JSX element.
  5. In line 60, there is a missing closing curly brace } for the JSX element.
  6. In line 79, there is a missing opening curly brace { for the JSX element.
  7. In line 101, there is a missing closing curly brace } for the JSX element.
  8. In line 124, there is a missing closing parenthesis ) for the useEffect hook.
  9. In line 136, there is a missing closing parenthesis ) for the useEffect hook.
  10. In line 145, there is a missing opening curly brace { for the JSX element.
  11. In line 155, there is a missing opening curly brace { for the JSX element.
  12. In line 158, the b element should be wrapped inside a JSX element for proper rendering.
  13. In line 198, there is a missing opening curly brace { for the JSX element.
  14. In line 199, there is a missing opening curly brace { for the JSX element.
  15. In line 201, there is a missing opening curly brace { for the JSX element.
  16. In line 206, there is a missing opening curly brace { for the JSX element.
  17. In line 222, there is a missing opening curly brace { for the JSX element.
  18. In line 242, there is a missing opening curly brace { for the JSX element.
  19. In line 283, there is a missing opening curly brace { for the JSX element.
  20. In line 284, there is a missing opening curly brace { for the JSX element.

File: packages/demoreact/src/app/app.tsx

  1. In line 222, the import statement for ChatWidgetTest is missing the curly braces {} around the component name.
  2. In line 362, there is a commented out line for ChatWidgetTest component. Please check if it is necessary and remove the comments if not needed.

File: packages/demoreact/src/app/context/envContext.ts

No issues found. All looks good.

Overall, the code seems to be fine with a few minor issues.

@0xNilesh 0xNilesh merged commit 8c57526 into feat/spaces-implementation Jul 19, 2023
1 check passed
@madhur-push madhur-push deleted the merge-alpha branch July 19, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants