Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spaces): join triggered twice due to faculty useEffect #552

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

madhur-push
Copy link
Contributor

No description provided.

@github-actions
Copy link

File: packages/restapi/src/lib/space/join.ts

  1. There is a missing closing bracket '}' at the end of the forEach loop starting at line 24.

  2. There is a missing closing bracket '}' at the end of the if statement starting at line 27.

  3. There is a missing closing bracket '}' at the end of the forEach loop starting at line 39.

  4. There is a missing closing bracket '}' at the end of the if statement starting at line 42.

  5. There is a missing closing bracket '}' at the end of the if statement starting at line 57.

  6. There is a missing closing bracket '}' at the end of the if statement starting at line 72.

  7. There is a missing closing bracket '}' at the end of the if statement starting at line 81.

  8. There is a missing closing bracket '}' at the end of the try block starting at line 91.

File: packages/restapi/src/lib/video/Video.ts

  1. There is a missing closing bracket '}' at the end of the if statement starting at line 71.

  2. There is a missing closing bracket '}' at the end of the forEach loop starting at line 73.

  3. There is a missing closing bracket '}' at the end of the if statement starting at line 87.

  4. There is a missing closing bracket '}' at the end of the if statement starting at line 106.

  5. There is a missing closing bracket '}' at the end of the if statement starting at line 140.

  6. There is a missing closing bracket '}' at the end of the if statement starting at line 150.

  7. There is a missing closing bracket '}' at the end of the if statement starting at line 173.

  8. There is a missing closing bracket '}' at the end of the if statement starting at line 196.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveWidgetContent.tsx

  • No issues found.

File: packages/uiweb/src/lib/dataProviders/SpaceDataProvider.tsx

  • No issues found.

All files look good.

@github-actions
Copy link

File: packages/restapi/src/lib/space/join.ts

  • options parameter is mentioned in the JSDoc but it's not used in the function. Please remove the unused parameter.

  • There is a missing closing brace } after the forEach loop for space.members. Please add the missing closing brace.

  • There is a missing closing brace } after the forEach loop for space.pendingMembers. Please add the missing closing brace.

  • There is a missing await keyword before the call to approve() function. Please add the await keyword.

  • There is a missing closing brace } after the await approve() statement. Please add the missing closing brace.

  • There is a missing closing brace } after the await this.request() statement. Please add the missing closing brace.

  • There is a missing closing brace } after the if (isSpeaker || isSpeakerPending) { condition. Please add the missing closing brace.

  • There is a missing closing brace } after the if (!isSpeaker && !isListner) { condition. Please add the missing closing brace.

  • There is a missing closing brace } after the console.log("UPDATED SPACE", updatedSpace); statement. Please add the missing closing brace.

File: packages/restapi/src/lib/video/Video.ts

  • There is a missing closing brace } after the JSON.stringify({ type: 'isVideoOn', value: this.data.local.video, }) statement. Please add the missing closing brace.

  • There is a missing closing brace } after the value: this.data.local.audio, statement. Please add the missing closing brace.

  • There is a missing closing brace } after the value: connectedAddresses, statement. Please add the missing closing brace.

  • There is a missing closing brace } after the value: parsedData.value statement. Please add the missing closing brace.

  • There is a missing closing brace } after the value: connectedAddresses, statement. Please add the missing closing brace.

  • There is a missing closing brace } after the value: parsedData.value statement. Please add the missing closing brace.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveWidgetContent.tsx

All looks good.

File: packages/uiweb/src/lib/dataProviders/SpaceDataProvider.tsx

All looks good.

@madhur-push madhur-push changed the title fix(spaces): join triggered twice due to faulty useEffect fix(spaces): join triggered twice due to faculty useEffect Jul 17, 2023
@0xNilesh 0xNilesh merged commit 7d4c227 into feat/spaces-implementation Jul 17, 2023
1 check passed
@0xNilesh 0xNilesh deleted the fix/join-space-triggered-twice branch July 17, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants