Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget/end space #551

Merged
merged 11 commits into from
Jul 18, 2023
Merged

Widget/end space #551

merged 11 commits into from
Jul 18, 2023

Conversation

samarendra-push
Copy link
Contributor

UI change on Ending a Space

@github-actions
Copy link

File: packages/uiweb/src/lib/components/space/SpaceWidget/EndWidgetContent.tsx

  • Line 5: The import statement is missing curly braces for Image and Text from '../../../config'.

  • Line 7: The import statement is missing SpaceInfoText.

  • Line 22: The gap property should have a value of '15px 0' instead of '15px'.

  • Line 28: The alt attribute for <Image> should have a more descriptive value, like "Space Ended Icon".

  • Line 39: The padding property for the <Item> component should have double curly braces, like padding={{ top: '9px', bottom: '9px', left: '34px', right: '34px' }}.

  • Line 44: The border property for the <Item> component should have a value of 'none' instead of ''.

  • Line 57: The fontSize property for the <Text> component should have a value of '16px' instead of "14px".

  • Line 82: There are multiple unnecessary empty lines at the end of the file. Please remove them.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveWidgetContent.tsx

  • Line 4: The import statement should be split into separate lines for each import.

  • Line 19: The import statement is missing curly braces for Text from '../../../config'.

  • Line 24: The import statement is missing curly braces for Player from '@livepeer/react'.

  • Line 26: The import statement is missing curly braces for restapi from '@pushprotocol/restapi'.

  • Line 31: The import statement is missing the import for createBlockie from '../helpers/blockies'.

  • Line 119: The cursor property for the <Item> component should have a value of 'pointer' instead of null.

  • Line 131: The cursor property for the <Image> component should be moved to a separate line.

  • Line 210: There is a missing closing parenthesis ) at the end of the line.

  • Line 287: There is a missing closing parenthesis ) at the end of the line.

  • Line 320: The fontWeight property for the <Text> component should have a value of '600' instead of 600.

  • Line 322: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 328: There is a missing closing parenthesis ) at the end of the line.

  • Line 353: There is a missing closing parenthesis ) at the end of the line.

  • Line 385: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 395: There is a missing closing parenthesis ) at the end of the line.

  • Line 402: There is an unnecessary empty line. Please remove it.

  • Line 466: The fontSize property for the <Text> component should have a value of '16px' instead of "16px".

  • Line 552: The closing tag for the <Button> component should be moved to a new line.

  • Line 605: The onClick attribute for the <Button> component should be wrapped in curly braces, like onClick={() => handleJoinSpace()}.

  • Line 605: The <CircularProgressSpinner /> component should be wrapped in curly braces, like {isLoading ? <CircularProgressSpinner /> : null}.

  • Line 619: The closing tag for the <Text> component should be moved to a new line.

  • Line 634: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 636: There is a missing closing parenthesis ) at the end of the line.

  • Line 638: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 640: There is a missing closing parenthesis ) at the end of the line.

  • Line 667: There is a missing closing parenthesis ) at the end of the line.

  • Line 692: The alt attribute for the second <Image> component should have a more descriptive value, like "Share Icon".

  • Line 706: The onClick attribute for the second <Image> component should be wrapped in curly braces, like onClick={() => setShowMembersModal(true)}.

  • Line 725: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 740: There is a missing opening parenthesis ( at the beginning of the line.

  • Line 768: There is an unnecessary empty line. Please remove it.

  • Line 862: There

@github-actions
Copy link

File: packages/uiweb/src/lib/components/space/SpaceWidget/EndWidgetContent.tsx

  • Line 16: Remove the import statement for SpaceInfoText, as it is not being used in the code.
  • Line 45: Remove the duplicate width prop on the Image component.
  • Line 65: Remove the unused prop padding from the Item component.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveWidgetContent.tsx

  • Line 47: Remove the unused prop setSpaceStatusState from the component props.
  • Line 59: Remove the duplicate width prop on the Image component.
  • Line 63: Remove the duplicate alt prop on the Image component.
  • Line 122: Add a missing closing parenthesis after the condition check.
  • Line 150: Update the condition check to (playBackUrl.length > 0) instead of (playBackUrl.lenghth > 0).
  • Line 175: Remove the unused alignContent prop from the Item component.
  • Line 190: Remove the duplicate width prop on the Image component.
  • Line 193: Remove the duplicate alt prop on the Image component.
  • Line 197: Remove the duplicate width prop on the Button component.
  • Line 237: Add the missing closing tag for the Player component.
  • Line 268: Remove the unused prop setSpaceStatusState from the component props.
  • Line 298: Remove the unused justify-content property from the DropDown styled component.

File: packages/uiweb/src/lib/components/space/reusables/ParticipantContainer.tsx

  • Line 8: Add a closing curly brace } after the justify-content: space-between; rule.

These are the changes needed to fix the mentioned issues. All other parts of the code look good.

@0xNilesh 0xNilesh merged commit 3cbff40 into feat/spaces-implementation Jul 18, 2023
1 check passed
@0xNilesh 0xNilesh deleted the widget/end-space branch July 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants