Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rft: widget refactors #548

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Conversation

arn4b
Copy link
Contributor

@arn4b arn4b commented Jul 17, 2023

No description provided.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as duplicate.

@github-actions
Copy link

In CreateSpaceTest.tsx:

  • The closing brackets for the update functions (updateContractAddressNFT, updateNumberOfNFTs, etc.) are missing, so you need to add closing brackets after each function definition.
  • The testCreateSpace function is missing a closing bracket, so you need to add a closing bracket after the setLoading(false) line.

In UpdateSpaceTest.tsx:

  • The closing brackets for the update functions (updateSpaceImage, updateMembers, etc.) are missing, so you need to add closing brackets after each function definition.
  • The updateSpaceId function is missing, so you need to add that function and include the corresponding setSpaceId logic.

In SpaceCreationWidget.tsx:

  • The closeInviteModal function is missing a closing bracket, so you need to add a closing bracket after the setIsInviteModalVisible(false) line.
  • The createSpace function is missing a closing bracket, so you need to add a closing bracket after the closeInviteModal() line.

In LiveSpaceProfileContainer.tsx:

  • The closing bracket for the else condition in the return statement is missing, so you need to add a closing bracket after the MicOffIcon line.

Please make the necessary changes and recheck your code before merging. All other files seem to be fine. All looks good.

@github-actions
Copy link

File: packages/demoreact/src/app/SpaceTest/CreateSpaceTest.tsx

  1. There are missing closing braces '}' after each function: updateContractAddressNFT, updateNumberOfNFTs, updateContractAddressERC20, updateNumberOfERC20, updateMeta, updateScheduleAt, and updateScheduleEnd.

  2. In the testCreateSpace function, isLoading should be setLoading.

  3. The return statement is missing a closing parenthesis on the last line.

File: packages/demoreact/src/app/SpaceTest/UpdateSpaceTest.tsx

  1. There are missing closing braces '}' after each function: updateSpaceImage, updateMembers, updateAdmins, updateScheduleAt, updateScheduleEnd, updateStatus, and updateAccount.

  2. In the updateSpaceTest function, isLoading should be setLoading.

  3. The return statement is missing a closing parenthesis on the last line.

File: packages/uiweb/src/lib/components/space/SpaceCreationWidget/SpaceCreationWidget.tsx

  1. In the createSpace function, closeInviteModal should be called before clearAllState.

  2. The return statement is missing a closing parenthesis on the last line.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveSpaceProfileContainer.tsx

  1. The last part of the render function, after the requested ? statement, is missing a closing parenthesis.

File: packages/uiweb/src/lib/components/space/SpaceWidget/LiveWidgetContent.tsx

  1. The file is empty and needs to be filled with code.

File: packages/uiweb/src/lib/components/space/SpaceWidget/ScheduledWidgetContent.tsx

  1. The file is empty and needs to be filled with code.

All other files are fine.

Copy link
Member

@0xNilesh 0xNilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xNilesh 0xNilesh merged commit 30331d7 into feat/spaces-implementation Jul 17, 2023
1 check passed
@0xNilesh 0xNilesh deleted the arnab/live-widget-rft branch July 17, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants