Create .env.sample for Restapi test cases #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur12-1610
force-pushed
the
1140
branch
2 times, most recently
from
005b784
to
d0f1bb1
Compare
|
@Aman035 I have added beforeAll hook, kindly review. |
ankur12-1610
changed the title
ankur12-1610
force-pushed
the
1140
branch
5 times, most recently
from
3de9cee
to
b9cda8c
Compare
Aman035
requested changes
Mar 11, 2024
packages/restapi/package.json
Outdated
| @@ -17,6 +17,7 @@ | |||
| "@metamask/eth-sig-util": "^5.0.2", | |||
| "buffer": "^6.0.3", | |||
| "crypto-js": "^4.1.1", | |||
| "envfile": "^7.1.0", | |||
There was a problem hiding this comment.
Add this as a dev dependency.
Anything that we add as dependency affects the build size
Since env verifier is only required for test cases, it should be added as a dev dependency.
There was a problem hiding this comment.
Done @Aman035!
Aman035
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#1140
Changes proposed
Create
.env.samplefor Restapi test casesCheck List (Check all the applicable boxes)
Screenshots
Note to reviewers