Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split: Add more examples #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

split: Add more examples #165

wants to merge 2 commits into from

Conversation

gasi
Copy link

@gasi gasi commented Nov 9, 2022

Description of the change

This change adds more examples to the String.split function and fixes a typo (occurences → occurrences).


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@gasi gasi changed the title String.split: Improve documentation split: Add more examples Nov 9, 2022
@gasi gasi force-pushed the patch-1 branch 3 times, most recently from 3f11d9d to f74f1a0 Compare November 9, 2022 18:35
- Add more examples
- Fix typo
CHANGELOG.md Outdated
@@ -11,6 +11,9 @@ New features:
Bugfixes:

Other improvements:
- `split` (#165)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you follow the formatting used in the rest of this changelog (e.g. including your username)?

If you want to provide more details, do something like this

- main entry (#PR by @<name>)

  Some more details here
  
- next main entry...

@michaelficarra
Copy link
Contributor

If you want more examples, you can add

  • adjacent matches:
split (Pattern "b") "abbc" == ["a", "", "c"]
  • overlapping matches:
split (Pattern "bb") "abbbc" == ["a", "bc"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants