Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss about InitPurescript #80

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

eiro
Copy link

@eiro eiro commented Jun 25, 2021

Trying to understand what InitPurescript tries to do is hard and there is no comment on it so i revamped, removed what seems useless, commented, made it optional (because i * don't want a plugin to touch my path ... it feels very intrusive to me) and documented it.

there is no mailing list to discuss about it so i left the changelog untouch for the moment and did not regen the doc.

Marc Chantreux added 5 commits June 25, 2021 11:45
* don't env the standard tools
* UUOC removed
* simplify *InitPureScript and rename it to PureScriptSetRoot
* introduce g:purescript_set_root and make PureScriptSetRoot call an
  option
* simplify includeexpr
@toastal
Copy link
Collaborator

toastal commented Dec 4, 2022

@eiro Hey. I'm maintaining this right now and I've been going through this from newest to oldest.

I don't fully understand your changes--or what's going on in the entire code base. I did notice that this plugin is trying to set up the root and nothing is pointing to more recent tooling. That said, I've dealt with code bases where there were nested spago.dhall files and I get incorrectly rooted. Maybe it's better if it's fully stripped and suggest a different tool like vim-rooter for that task?

Currently, I've given up on tools trying to be clever and use vim-rooter with

vim.g.rooter_patterns = {
	"flake.nix",
	"shell.nix",
	".git",
	".hg",
	".pijul",
	"_darcs",
	"Makefile",
}

mailing list

Created yesterday if preferable: https://lists.sr.ht/~toastal/purescript-vim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants