Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ifolded and imapped (closes #147) #147

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

twhitehead
Copy link
Contributor

Description of the change

This adds the ifolded and imapped functions to provide an IndexedFold and an IndexedSetter for all instances of FoldableWithIndex and FunctorWithIndex as itraversed provides an IndexedTraversal for all instances of TraversableWithIndex


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@garyb
Copy link
Member

garyb commented Aug 29, 2024

This PR failure is nothing to do with you, but would you mind updating the package set ref from prepare-0.15 to psc-0.15.15-20240829 or something recent like that? That should fix it!

@twhitehead
Copy link
Contributor Author

Thanks. Noticed my layout, with respect to line breaks, didn't exactly follow that of the existing file too, so fixed that as well.

@twhitehead twhitehead changed the title Add ifolded and imapped (closes # Add ifolded and imapped (closes #147) Aug 29, 2024
@twhitehead
Copy link
Contributor Author

@garyb Seems to still be dying on some CI build item unrelated to this pull request

...

purescript-refs#6.0.0 bower_components/purescript-refs
├── purescript-effect#4.0.0
└── purescript-prelude#6.0.1
* Building project in /home/runner/work/purescript-profunctor-lenses/purescript-profunctor-lenses
* Unable to parse the version from psa. (It was: v0.9.0)
* Please check that the right executable is on your PATH.
Invalid option `--censor-lib'

Usage: purs COMMAND

  The PureScript compiler and tools
* ERROR: Subcommand terminated with exit code 1

Any ideas? It built fine on my machine using spago once I converted spago.dhall to spago.yaml.

@garyb
Copy link
Member

garyb commented Aug 30, 2024

Hmm, yeah this is a pulp and psa build related thing, but I'm not really sure why it's a problem now.

I think changing the CI line:

npx pulp build -- --censor-lib --strict

to just:

npx pulp build

should get it through.

twhitehead added a commit to twhitehead/purescript-profunctor-lenses that referenced this pull request Sep 6, 2024
@garyb
Copy link
Member

garyb commented Sep 8, 2024

Sorry, looks like you changed the wrong line there. It's not the spago build that is problematic, it's the usage of pulp in the Verify Bower & Pulp task. Line 46 🙂.

I'd edit this myself to make the fix rather than subjecting you to the busywork, but I don't think I can because it's coming from your main branch.

@twhitehead
Copy link
Contributor Author

Sorry about that. Hopefully I got it right this time. 🤞

@garyb
Copy link
Member

garyb commented Sep 18, 2024

That did the trick, thanks!

@garyb garyb merged commit 1441836 into purescript-contrib:main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants