Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ip[6]tables protocol in firewallchain #1191

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jcharaoui
Copy link
Contributor

Summary

This mirrors the values accepted for the firewall provider.

Additional Context

If a firewallchain resource is defined with protocol => 'ip6tables', this fails with error Execution of '' returned 1: Error: Could not execute posix command: no implicit conversion of nil into String

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@jcharaoui jcharaoui requested a review from a team as a code owner February 23, 2024 22:19
@jerome2710
Copy link

Subscribing... my ipv6 rules fail as well:

Notice: firewall[003 IPv6]: Creating: Creating Rule '003 IPv6' with {:name=>"003 IPv6", :ensure=>"present", :protocol=>"ip6tables", :chain=>"WHITELIST", :source=>"...redacted...", :destination=>nil, :proto=>"tcp", :dport=>"22", :jump=>"ACCEPT", :table=>"filter"}
Debug: Executing: ''
Error: firewall[003 IPv6]: Creating: Failed after 0.007595 seconds: Execution of '' returned 1: Error: Could not execute posix command: no implicit conversion of nil into String
Error: /Stage[main]/Profile::Firewall::Pre/Firewall[003 IPv6]: Could not evaluate: Execution encountered an error

@bastelfreak
Copy link
Collaborator

@jcharaoui can you please rebase against main to get rid of the merge commit?

@jcharaoui
Copy link
Contributor Author

@jcharaoui can you please rebase against main to get rid of the merge commit?

Done!

@redat00
Copy link

redat00 commented Sep 22, 2024

Hi !

I just tested this and was able to get my IPv6 rules working as expected with this fix.. Otherwise it would not.
Any idea if this could be merged somehow ?

Thanks in advance ! In the meantime I'll just clone the module and make the fix locally.

This mirrors the values accepted for the firewall provider.
@malikparvez malikparvez merged commit 2ef3ddc into puppetlabs:main Sep 23, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants