(CONT-962) Tempoarily disable all testing prior to update to account …

…fo resource_api Includes removal of workflow mistakenly added back during rebase
puppetlabs · Jul 18, 2023 · e067e01 · e067e01
1 parent f5b7ec9
commit e067e01
Show file tree

Hide file tree

Showing 24 changed files with 6,261 additions and 687 deletions.
diff --git a/.github/workflows/auto_release.yml b/.github/workflows/auto_release.yml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,11 +7,11 @@ on:
   workflow_dispatch:
 
 jobs:
-  Spec:
-    uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
-    with:
-      runs_on: "ubuntu-20.04"
-    secrets: "inherit"
+  # Spec:
+  #   uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
+  #   with:
+  #     runs_on: "ubuntu-20.04"
+  #   secrets: "inherit"
 
   Acceptance:
     needs: Spec

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-07-18 14:58:39 UTC using RuboCop version 1.48.1.
+# on 2023-07-18 16:00:50 UTC using RuboCop version 1.48.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -16,6 +16,12 @@ Layout/EmptyLineAfterGuardClause:
     - 'lib/puppet/Old/type/firewall.rb'
     - 'lib/puppet/Old/util/firewall.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLines:
+  Exclude:
+    - 'spec/acceptance/rules_spec.rb'
+
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -57,12 +63,22 @@ Lint/DuplicateBranch:
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
     - 'lib/puppet/Old/util/firewall.rb'
 
-# Offense count: 2
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'spec/acceptance/firewall_attributes_exceptions_spec.rb'
+    - 'spec/unit/puppet/provider/ip6tables_spec.rb'
+    - 'spec/unit/puppet/provider/iptables_chain_spec.rb'
+    - 'spec/unit/puppet/provider/iptables_spec.rb'
+    - 'spec/unit/puppet/type/firewall_spec.rb'
+    - 'spec/unit/puppet/util/firewall_spec.rb'
+
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Lint/RedundantCopEnableDirective:
   Exclude:
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
-    - 'spec/unit/classes/firewall_spec.rb'
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -156,15 +172,7 @@ Performance/StringInclude:
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
     - 'lib/puppet/Old/type/firewall.rb'
 
-# Offense count: 5
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
-    - 'spec/unit/classes/firewall_linux_spec.rb'
-
-# Offense count: 7
+# Offense count: 2
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Exclude:
@@ -173,29 +181,9 @@ RSpec/DescribeClass:
     - '**/spec/routing/**/*'
     - '**/spec/system/**/*'
     - '**/spec/views/**/*'
-    - 'spec/unit/classes/firewall_linux_archlinux_spec.rb'
-    - 'spec/unit/classes/firewall_linux_debian_spec.rb'
-    - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
-    - 'spec/unit/classes/firewall_linux_spec.rb'
-    - 'spec/unit/classes/firewall_spec.rb'
     - 'spec/unit/facter/iptables_persistent_version_spec.rb'
     - 'spec/unit/puppet/type/firewallchain_spec.rb'
 
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterExample:
-  Exclude:
-    - 'spec/unit/classes/firewall_linux_archlinux_spec.rb'
-    - 'spec/unit/classes/firewall_linux_debian_spec.rb'
-    - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterExampleGroup:
-  Exclude:
-    - 'spec/unit/classes/firewall_spec.rb'
-
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowConsecutiveOneLiners.
@@ -204,30 +192,15 @@ RSpec/EmptyLineAfterHook:
     - 'spec/unit/facter/iptables_persistent_version_spec.rb'
     - 'spec/unit/facter/iptables_spec.rb'
 
-# Offense count: 4
+# Offense count: 1
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 11
 
-# Offense count: 41
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
-RSpec/ImplicitSubject:
-  Exclude:
-    - 'spec/unit/classes/firewall_linux_archlinux_spec.rb'
-    - 'spec/unit/classes/firewall_linux_debian_spec.rb'
-    - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
-
-# Offense count: 10
+# Offense count: 1
 RSpec/MultipleExpectations:
   Max: 2
 
-# Offense count: 3
-RSpec/RepeatedExampleGroupBody:
-  Exclude:
-    - 'spec/unit/classes/firewall_linux_debian_spec.rb'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: .
@@ -247,6 +220,13 @@ Style/ConcatArrayLiterals:
   Exclude:
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
 
+# Offense count: 21
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 # Offense count: 73
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
@@ -357,7 +337,7 @@ Style/SymbolProc:
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
     - 'lib/puppet/Old/type/firewall.rb'
 
-# Offense count: 41
+# Offense count: 13
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -366,9 +346,5 @@ Style/TrailingCommaInHashLiteral:
     - 'lib/puppet/Old/provider/firewall/ip6tables.rb'
     - 'lib/puppet/Old/provider/firewall/iptables.rb'
     - 'lib/puppet/Old/provider/firewallchain/iptables_chain.rb'
-    - 'spec/unit/classes/firewall_linux_archlinux_spec.rb'
-    - 'spec/unit/classes/firewall_linux_debian_spec.rb'
-    - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
-    - 'spec/unit/classes/firewall_linux_spec.rb'
     - 'spec/unit/facter/iptables_persistent_version_spec.rb'
     - 'spec/unit/puppet/provider/firewallchain/firewallchain_spec.rb'
diff --git a/spec/acceptance/class_spec.rb b/spec/acceptance/class_spec.rb
@@ -0,0 +1,26 @@
+# # frozen_string_literal: true
+
+# require 'spec_helper_acceptance'
+
+# describe 'firewall class' do
+#   before(:all) do
+#     if os[:family] == 'ubuntu' || os[:family] == 'debian'
+#       update_profile_file
+#     end
+#   end
+
+#   it 'runs successfully', unless: os[:family] == 'redhat' && os[:release].to_i == 6 do
+#     pp = "class { 'firewall': }"
+#     idempotent_apply(pp)
+#   end
+
+#   it 'ensure => stopped:', unless: os[:family] == 'redhat' && os[:release].to_i == 6 do
+#     pp = "class { 'firewall': ensure => stopped }"
+#     idempotent_apply(pp)
+#   end
+
+#   it 'ensure => running:', unless: os[:family] == 'redhat' && os[:release].to_i == 6 do
+#     pp = "class { 'firewall': ensure => running }"
+#     idempotent_apply(pp)
+#   end
+# end