Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribe request timeout #460

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Fix subscribe request timeout #460

merged 3 commits into from
Jul 8, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Jul 3, 2024

fix(subscribe): fix subscribe request timeout

Fix issue because of which wrong request timeout has been used.

fix(subscribe): fix user timetoken parse

Fix issue with PNSubscribeCursorData which should have an optional region to handle user timetoken in received real-time messages.

Fix issue because of which wrong request timeout has been used.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: fix This PR contains fixes to existing features. labels Jul 3, 2024
@parfeon parfeon self-assigned this Jul 3, 2024
@parfeon parfeon requested a review from jguz-pubnub as a code owner July 3, 2024 16:57
Fix issue with `PNSubscribeCursorData` which should have optional `region` to handle  user
timetoken in received real-time messages.
@parfeon
Copy link
Contributor Author

parfeon commented Jul 8, 2024

@pubnub-release-bot release

@parfeon parfeon merged commit 31fdf33 into master Jul 8, 2024
7 checks passed
@parfeon parfeon deleted the ENG-8349-fix-timeout branch July 8, 2024 17:45
@pubnub-release-bot
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: fix This PR contains fixes to existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants