JSON decoder / encoder #459
Conversation
Decoder to map server response directly to the data models. feat: request / response based interface Configurable request objects require less convenience methods to interact with PubNub REST API. feat: network layer rewritten as module
parfeon
added
status: in progress
Example/PubNub/PNAppDelegate.m
Outdated
| @@ -61,8 +61,8 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
| self.channel1 = @"bot"; | |||
| self.channel2 = @"myCh"; | |||
| self.channelGroup1 = @"myChannelGroup"; | |||
| self.pubKey = @"demo"; | |||
| self.subKey = @"demo"; | |||
| self.pubKey = @"pub-c-92e62c76-408a-4ac4-aefc-a1d20a83b2a6"; | |||
PubNub/Core/PubNub+APNS.m
Outdated
| PNPushNotificationsStateAuditCompletionBlock block = [handlerBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
There was a problem hiding this comment.
We could consider checking against the PUBNUB_DISABLE_LOGGER flag as a part of PNLogAPICall, so we would have such a check in one place only. Another idea could be overriding debugDescription for objects like userRequest. These two should shorten the overall syntax for logging. Let's leave it for now and consider pros and cons in the future
PubNub/Core/PubNub+Objects.m
Outdated
| PNSetUUIDMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
There was a problem hiding this comment.
Looks like it's not used
There was a problem hiding this comment.
I can drop it. Just added as a placeholder (it still will be stripped away during compilation).
PubNub/Core/PubNub+Objects.m
Outdated
| PNRemoveUUIDMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
There was a problem hiding this comment.
The same, looks like it's not used
PubNub/Core/PubNub+Objects.m
Outdated
| PNFetchUUIDMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
There was a problem hiding this comment.
The same, looks like it's not used
PubNub/Core/PubNub+Objects.m
Outdated
| PNFetchAllUUIDMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
PubNub/Core/PubNub+Objects.m
Outdated
| PNSetChannelMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
PubNub/Core/PubNub+Objects.m
Outdated
| PNRemoveChannelMetadataCompletionBlock block = [handleBlock copy]; | ||
| PNParsedRequestCompletionBlock handler; | ||
|
|
||
| #ifndef PUBNUB_DISABLE_LOGGER |
There was a problem hiding this comment.
Here too, perhaps the best way would be to find all these empty occurrences and delete them
There was a problem hiding this comment.
All Object API files has this as a placeholder. Need to sneak pick into another language which prints something and repeat the message here :)
refactor(json): adjust JSON serializer to the project needs Adjust model mapping keys set and type configurations in models. test: fix test suite
…om:pubnub/objective-c into modernization/request-response-data-models
…om:pubnub/objective-c into modernization/request-response-data-models
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
feat: JSON decoder / encoder
Decoder to map server response directly to the data models.
feat: request / response-based interface
Configurable request objects require less convenience methods to interact with PubNub REST API.
feat: network layer rewritten as module