Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue of registered listener is not being remove on RemoveListener. #227

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: issue of registered listener is not being remove on RemoveListener. #227

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b8125
fix: issue of registered listener is not being remove on RemoveListener.
mohitpubnub Sep 30, 2024
6e8caee
Update CODEOWNERS
mohitpubnub Oct 3, 2024
9b4033a
PubNub SDK v6.20.2.0 release.
pubnub-release-bot Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
* @mohitpubnub @xavrax @marcin-cebo
README.md @techwritermat @kazydek @mohitpubnub @xavrax
* @mohitpubnub @xavrax @marcin-cebo @jakub-grzesiowski
README.md @techwritermat @kazydek @mohitpubnub @xavrax @jakub-grzesiowski
21 changes: 12 additions & 9 deletions src/Api/PubnubApi/Pubnub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,15 +412,18 @@ public bool AddListener(SubscribeCallback listener)
}
}

public bool RemoveListener(SubscribeCallback listener)
{
bool ret = false;
if (subscribeCallbackListenerList != null)
{
ret = subscribeCallbackListenerList.Remove(listener);
}
return ret;
}
public bool RemoveListener(SubscribeCallback listener)
{
bool ret = false;
if (subscribeCallbackListenerList != null) {
ret = subscribeCallbackListenerList.Remove(listener);
}
if (listenerManager != null) {
var removeFromListenerManager = listenerManager.RemoveListener(listener);
if (!ret) ret = ret || removeFromListenerManager;
}
return ret;
}
#endregion

public EndPoint.SendFileOperation SendFile()
Expand Down
Loading