info_schema_tables: do not collect the (useless) sys schema
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm estimating this to be a fairly simple PR, so (according to https://github.com/prometheus/mysqld_exporter/blob/main/CONTRIBUTING.md): Thanks :) |
Signed-off-by: Florent Rivoire <frivoire@users.noreply.github.com>
frivoire
changed the title
sys schemasys schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
sysschema is another (mariadb-specific) "system" schema, introduced in MariaDB 10.6 (2021), cf: MariaDB's docEDIT: MySQL seems to be introducing also a
sysschema in MySQL 8.4 (2024), cf: MySQL's docAnd it's not useful to collect metrics for this schema (and it's even counter-productive, cf the cost of storing the metrics afterwards).
So, let's just remove this schema, just like it's already performed for the other "system" schemas (ex:
performance_schema) today to be consistent with all "system" schemas.Note: it's my first PR here, so I'm not sure about the CI/tests, please forgive any mistake & tell me 🙏