Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add marks #478

Merged
merged 8 commits into from
Sep 14, 2023
Merged

feat: add marks #478

merged 8 commits into from
Sep 14, 2023

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jul 14, 2023

marks are a special type of tags, which get their own icon and prominent toggle

@Yelinz
Copy link
Member Author

Yelinz commented Aug 2, 2023

@anehx do you have an idea how let the consumers define the used icons through alexandria for fontawsome?
These are some issues I looked at which hint at the same problem. FortAwesome/ember-fontawesome#45 FortAwesome/ember-fontawesome#8
Otherwise it might need to be configured just to include all the icons?

@anehx
Copy link
Contributor

anehx commented Aug 3, 2023

@anehx do you have an idea how let the consumers define the used icons through alexandria for fontawsome? These are some issues I looked at which hint at the same problem. FortAwesome/ember-fontawesome#45 FortAwesome/ember-fontawesome#8 Otherwise it might need to be configured just to include all the icons?

I think that's what config/icons.js is used for.

@Yelinz
Copy link
Member Author

Yelinz commented Aug 7, 2023

image
image
image
Different states of the ui with the mark icons
@anehx @czosel is it visually ok

addon/services/tags.js Outdated Show resolved Hide resolved
marks are a special type of tags, which get their own icon and prominent
toggle
@czosel
Copy link
Contributor

czosel commented Sep 14, 2023

Otherwise LGTM 👍

@czosel czosel merged commit 0381737 into main Sep 14, 2023
11 checks passed
@velrest
Copy link
Contributor

velrest commented Sep 14, 2023

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Yelinz Yelinz deleted the marks branch November 9, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants