fix(search): add preventDefault to submit

Enter inside a text-input submits the form which is a problem.
projectcaluma · Feb 9, 2021 · 042d24d · 042d24d
1 parent 73614ee
commit 042d24d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/addon/components/search.hbs b/addon/components/search.hbs
@@ -1,4 +1,7 @@
-<div class="uk-background-muted uk-padding-small uk-border-bottom">
+<div
+  class="uk-background-muted uk-padding-small uk-border-bottom"
+  {{on "submit" this.onSubmit}}
+>
   <form class="uk-background-default uk-search uk-search-default uk-width-1">
     <a href="" uk-search-icon></a>
     <input

diff --git a/addon/components/search.js b/addon/components/search.js
@@ -1,3 +1,4 @@
+import { action } from "@ember/object";
 import { inject as service } from "@ember/service";
 import Component from "@glimmer/component";
 import { timeout } from "ember-concurrency";
@@ -6,6 +7,10 @@ import { restartableTask } from "ember-concurrency-decorators";
 export default class SearchComponent extends Component {
   @service router;
 
+  @action onSubmit(event) {
+    event.preventDefault();
+  }
+
   @restartableTask *updateSearch({ target: { value: search } }) {
     if (!Ember.testing) {
       yield timeout(1000);