Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV changes related to CSP #3878

Merged
merged 9 commits into from
Aug 14, 2023
Merged

ENV changes related to CSP #3878

merged 9 commits into from
Aug 14, 2023

Conversation

VISHNUDAS-tunerlabs
Copy link
Contributor

Confluence Doc: Confluence Link
JIRA Ticket: JIRA Link
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Software versions:
  • Hardware versions:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gandham-santhosh
Copy link
Collaborator

@VISHNUDAS-tunerlabs there are CSP name references present in this file like Azure OCI. Also, there are variables defined multiple times which are commented. Can you please correct these?

@gandham-santhosh gandham-santhosh merged commit da25f00 into project-sunbird:release-6.0.0 Aug 14, 2023
santhosh-tg pushed a commit to santhosh-tg/sunbird-devops that referenced this pull request Sep 29, 2023
* envChange CSP(Azure)

* CSP env changes

* removed csp references

* env changes for core service

* default added

* added all variables

* env variable name change

* ENV changes

* Changes to env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants