Merge pull request #190 from praveenKDass/release-6.0.0_cloud

changes:getDownloable URL issue fixes for GCP
project-sunbird · Jul 19, 2024 · fa09c1f · fa09c1f
2 parents a99552d + ba9aa51
commit fa09c1f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/module/files/helper.js b/module/files/helper.js
@@ -159,14 +159,14 @@ module.exports = class FilesHelper {
             file: file,
             payload: { sourcePath: file },
             cloudStorage: cloudStorage.toUpperCase(),
-          };
-          if (process.env.CLOUD_STORAGE_PROVIDER !== constants.common.G_CLOUD) {
-            response.downloadableUrl = await cloudClient.getDownloadableUrl(
-              bucket,
-              file,
-              linkExpireTime // Link ExpireIn
+          };         
+          // Generate a read-only pre-signed URL for downloading a file from the Cloud bucket
+            response.getDownloadableUrl = await cloudClient.getSignedUrl(
+              bucket,         // bucket name
+              file,           // file path
+              linkExpireTime, // expire
+              constants.common.READ_PERMISSION  // read/write
             );
-          }
           if (!serviceUpload) {
             response.url = await cloudClient.getSignedUrl(
               bucket, // bucket name