hash to curve suite #146

kilic · 2024-03-26T06:36:16Z

Hash to curve suites added so we are passing test vectors at draft-irtf-cfrg-hash-to-curve-14However vectors we can run are only for SSWU method so there is no test against SVDW.

CurveExt::hash_to_curve implements the default method but user can make its own combination using hash_to_curve::Suite
~~Fixed FromUniformBytes<64> at pluto eris side.~~
Now it uses single implementation for montgommery_form

Should close #145

duguorong009

I am sure it looks good overall.
Pls remove the leftovers I found.

src/hash_to_curve.rs

src/pluto_eris/fields/fq.rs

src/hash_to_curve.rs

Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>

davidnevadoc

I have left some comments, great changes overall!
I'll give it the final pass next week.

src/secq256k1/curve.rs

src/grumpkin/curve.rs

src/bn256/mod.rs

src/pluto_eris/fields/mod.rs

src/derive/field.rs

Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>

davidnevadoc

Final pass: Just left some comments about FromUniformBytes implementations.
Will approve once the comments are addressed. Great job! 👍

src/secp256r1/curve.rs

src/pluto_eris/curve.rs

src/secp256r1/curve.rs

davidnevadoc

LGTM!

kilic marked this pull request as draft March 26, 2024 06:36

add hash to curve suite

368c5da

kilic force-pushed the h2c-suite branch from a738da4 to 368c5da Compare March 26, 2024 23:03

kilic marked this pull request as ready for review March 26, 2024 23:04

davidnevadoc self-requested a review April 1, 2024 16:46

duguorong009 reviewed Apr 5, 2024

View reviewed changes

src/hash_to_curve.rs Outdated Show resolved Hide resolved

src/pluto_eris/fields/fq.rs Outdated Show resolved Hide resolved

davidnevadoc reviewed Apr 5, 2024

View reviewed changes

src/hash_to_curve.rs Show resolved Hide resolved

src/hash_to_curve.rs Outdated Show resolved Hide resolved

kilic and others added 3 commits April 5, 2024 13:26

Update comment

bffbc81

Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>

remove lefovers

d9d292b

update references of test vectors

2d8a8da

davidnevadoc reviewed Apr 7, 2024

View reviewed changes

src/secq256k1/curve.rs Outdated Show resolved Hide resolved

src/grumpkin/curve.rs Outdated Show resolved Hide resolved

src/bn256/mod.rs Show resolved Hide resolved

src/pluto_eris/fields/mod.rs Outdated Show resolved Hide resolved

src/derive/field.rs Show resolved Hide resolved

Fix domain name

81289d7

Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>

davidnevadoc reviewed Apr 12, 2024

View reviewed changes

src/secp256r1/curve.rs Outdated Show resolved Hide resolved

src/pluto_eris/curve.rs Show resolved Hide resolved

rollback nonsense pluto from_u512 change

9ea0785

davidnevadoc reviewed May 6, 2024

View reviewed changes

src/secp256r1/curve.rs Outdated Show resolved Hide resolved

davidnevadoc mentioned this pull request May 10, 2024

FromUniformBytes<64> may not be fitting for large fields. privacy-scaling-explorations/halo2#324

Open

kilic added 5 commits May 13, 2024 23:51

add bn256 g1 hash to curve test vectors

f4465d6

add bn256 g2 hash to curve test vectors

9f1a31c

tidy

6739ab8

reuse FromUniformBytes<64> when possible

67899ec

remove old blake2 dep

59e5753

davidnevadoc approved these changes May 24, 2024

View reviewed changes

kilic added this pull request to the merge queue May 24, 2024

Merged via the queue into privacy-scaling-explorations:main with commit f7c6b4c May 24, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hash to curve suite #146

hash to curve suite #146

kilic commented Mar 26, 2024 •

edited

Loading

duguorong009 left a comment

davidnevadoc left a comment

davidnevadoc left a comment

davidnevadoc left a comment

hash to curve suite #146

hash to curve suite #146

Conversation

kilic commented Mar 26, 2024 • edited Loading

duguorong009 left a comment

Choose a reason for hiding this comment

davidnevadoc left a comment

Choose a reason for hiding this comment

davidnevadoc left a comment

Choose a reason for hiding this comment

davidnevadoc left a comment

Choose a reason for hiding this comment

kilic commented Mar 26, 2024 •

edited

Loading