-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hash to curve suite #146
hash to curve suite #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure it looks good overall.
Pls remove the leftovers I found.
Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments, great changes overall!
I'll give it the final pass next week.
Co-authored-by: David Nevado <davidnevadoc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final pass: Just left some comments about FromUniformBytes
implementations.
Will approve once the comments are addressed. Great job! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f7c6b4c
Hash to curve suites added so we are passing test vectors at
draft-irtf-cfrg-hash-to-curve-14
However vectors we can run are only forSSWU
method so there is no test againstSVDW
.CurveExt::hash_to_curve
implements the default method but user can make its own combination usinghash_to_curve::Suite
FixedFromUniformBytes<64>
at pluto eris side.montgommery_form
Should close #145