-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lib to 0.6.0 #125
Bump lib to 0.6.0 #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged the PR #124.
Hence, pls go for merge/rebase the changes.
@@ -12,7 +12,7 @@ This library provides efficient and flexible implementations of various halo2-fr | |||
|
|||
The implementations were originally ported from [matterlabs/pairing](https://github.com/matter-labs/pairing/tree/master/src/bn256) and [zkcrypto/bls12-381](https://github.com/zkcrypto/bls12_381), but have been extended and optimized to cover a broader set of curves and use cases. Since its initial release, the library has expanded to include additional curves, along with the following features: | |||
|
|||
* `secp256k1`, `secp256r1`, and `grumpkin` curves, enhancing its usability across a range of cryptographic protocols. | |||
* `secp256k1`, `secp256r1`, `pluto`, `eris` and `grumpkin` curves, enhancing its usability across a range of cryptographic protocols. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep it as is. Since they're 2 different curves. We follow the same rationale for the secp cycle indeed.
@@ -59,4 +59,4 @@ The library's top-level directories are organized as follows: | |||
|
|||
* `benches`: Contains benchmarking tests. | |||
* `script`: Contains utility scripts. | |||
* `src`: Contains the source code of the library, further subdivided into modules for each supported curve (`bn256`, `grumpkin`, `secp256k1`, `secp256r1`, `pasta`) and additional functionalities (`derive`, `tests`). | |||
* `src`: Contains the source code of the library, further subdivided into modules for each supported curve (`bn256`, `grumpkin`, `secp256k1`, `secp256r1`, `secq256k1`, `pasta`, `pluto`, `eris`) and additional functionalities (`derive`, `tests`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
pluto/eris
or pluto-eris
is more clear, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's Changed
secp256k1
by @duguorong009 in feat: implement the SSWU hash_to_curve forsecp256k1
#110maybe_rayon
torayon-1.8
by @CPerezz in change: Move frommaybe_rayon
torayon-1.8
#122utils
module by @CPerezz in Add FieldBits impl for Secp256r1 & removeutils
module #123iso_map_secp256k1
by @duguorong009 in improve: avoid the inversions iniso_map_secp256k1
#124New Contributors
secp256k1
#110Full Changelog: v0.5.0...v0.6.0