Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lib to 0.6.0 #125

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Bump lib to 0.6.0 #125

merged 2 commits into from
Jan 10, 2024

Conversation

CPerezz
Copy link
Member

@CPerezz CPerezz commented Jan 9, 2024

What's Changed

New Contributors

Full Changelog: v0.5.0...v0.6.0

Copy link
Contributor

@duguorong009 duguorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged the PR #124.
Hence, pls go for merge/rebase the changes.

@@ -12,7 +12,7 @@ This library provides efficient and flexible implementations of various halo2-fr

The implementations were originally ported from [matterlabs/pairing](https://github.com/matter-labs/pairing/tree/master/src/bn256) and [zkcrypto/bls12-381](https://github.com/zkcrypto/bls12_381), but have been extended and optimized to cover a broader set of curves and use cases. Since its initial release, the library has expanded to include additional curves, along with the following features:

* `secp256k1`, `secp256r1`, and `grumpkin` curves, enhancing its usability across a range of cryptographic protocols.
* `secp256k1`, `secp256r1`, `pluto`, `eris` and `grumpkin` curves, enhancing its usability across a range of cryptographic protocols.
Copy link
Contributor

@duguorong009 duguorong009 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to use the pluto-eris or pluto/eris for the names of new curves.
The reason is it delivers more clear meaning. (like here)
What do you think? @CPerezz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep it as is. Since they're 2 different curves. We follow the same rationale for the secp cycle indeed.

@@ -59,4 +59,4 @@ The library's top-level directories are organized as follows:

* `benches`: Contains benchmarking tests.
* `script`: Contains utility scripts.
* `src`: Contains the source code of the library, further subdivided into modules for each supported curve (`bn256`, `grumpkin`, `secp256k1`, `secp256r1`, `pasta`) and additional functionalities (`derive`, `tests`).
* `src`: Contains the source code of the library, further subdivided into modules for each supported curve (`bn256`, `grumpkin`, `secp256k1`, `secp256r1`, `secq256k1`, `pasta`, `pluto`, `eris`) and additional functionalities (`derive`, `tests`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.
pluto/eris or pluto-eris is more clear, I think.

Copy link
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CPerezz CPerezz added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit e4185d6 Jan 10, 2024
11 checks passed
mratsim added a commit to mratsim/constantine that referenced this pull request Jan 22, 2024
@duguorong009 duguorong009 mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants