Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Move from maybe_rayon to rayon-1.8 #122

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Commits on Jan 5, 2024

  1. change: Move from maybe_rayon to rayon-1.8

    After seeing the issues with WASM that the last release (`0.5.0`) of
    this crate made, the idea is to now control the compatibility with WASM
    while at the same time, making it easy to handle.
    
    In this line of work, the idea was to simply do the following:
    - Use `rayon 1.8` as a dependency for paralellism which fixes the WASM
      compat issues with `multicore`-related things. See: rayon-rs/rayon#1019
      thanks @han0110 for the suggestion.
    - Use conditional dev-dependency loading for `getrandom` such that we
      can compile the lib for WASM-targets in the CI without needing to have
      the dependency being pulled downstream.
    - The `multicore` module is gone, and the rest of the code has been
      refactored since the "fallback" is now handled by rayon itself.
    CPerezz committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    39f280b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    deca3dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2588674 View commit details
    Browse the repository at this point in the history
  4. chore: Fix CI missing "

    CPerezz committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a96d02e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c5acdaf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9189a10 View commit details
    Browse the repository at this point in the history
  7. chore: Address review nits

    CPerezz committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    3f58eff View commit details
    Browse the repository at this point in the history