[#26] 소셜로그인 구현 #53
Merged
[#26] 소셜로그인 구현 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
XionWCFM
reviewed
Apr 9, 2024
| import { ReactQueryDevtools } from '@tanstack/react-query-devtools' | ||
| import { ReactQueryStreamedHydration } from '@tanstack/react-query-next-experimental' | ||
| import React, { useState } from 'react' |
There was a problem hiding this comment.
React.useState를 useState로 바꾸는건 좋은 것 같아요
useState로 바꿨으면 React 임포트를 제거해서 용량아끼기까지 하면 더 좋겠내요
| setLoginUser(data.data.token) | ||
| router.push('/main') | ||
| } catch (error) { | ||
| console.error('인증 코드가 존재하지 않습니다.') |
There was a problem hiding this comment.
🔥 나중엔 에러처리에 Toast 같이 사용자도 에러상황을 인지할 수 있게해주는 UI가 들어가면 좋을거같아요
| if (codeParam) { | ||
| try { | ||
| const data = await postOAuth(codeParam) | ||
| localStorage.setItem('accessToken', data.data.token) |
There was a problem hiding this comment.
👍 localstroage의 키를 하드코딩하고있는건 나중에 상수화해서 관리하거나 로컬스토리지 자체를 하나의 레이어로 만들어서 관리하면 더 좋을거가타요
| const params = useSearchParams() | ||
| const codeParam = params.get('code') | ||
| const [, setLoginUser] = useRecoilState(userKakaoTokenAtom) |
There was a problem hiding this comment.
recoil, jotai같은 아톰라이브러리들은 setter만 제공하는 useSetRecoilState같은 함수를 제공하니까 세터만 쓰려고하는 경우엔 이쪽 함수를 사용해보는것도 좋지않을까싶내요
| export const resultAtom = atom<number>({ | ||
| key: 'resultAtom', | ||
| default: 0, | ||
| }) | ||
|
|
||
| // 적극적 투자 지표 사용자가 선택한 항목 |
There was a problem hiding this comment.
주석 달아준거 너무 친절해요 👍 코딩할때 인텔리센스로도 생성되면 좋을거같아요 jsdoc으로 설명을 붙여주면 더 좋지않을까요?
|
@XionWCFM 시온 머야 ?! 완전 감동 !!!!! 편지는 짧지만 애정 미쳐따 ~~ 🥺😆🔥🔥 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
카카오 소셜로그인 개발을 하였습니다
중요한 포인트