Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note in Flash and PageHead for accessibility #859

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add note in Flash and PageHead for accessibility #859

merged 2 commits into from
Sep 17, 2024

Conversation

TylerJDev
Copy link
Contributor

Adds more accessibility guidance for Flash and PageHead. Relates to the following issues:

@TylerJDev TylerJDev mentioned this pull request Sep 13, 2024
Merged
13 tasks
@TylerJDev TylerJDev marked this pull request as ready for review September 13, 2024 19:33
@TylerJDev TylerJDev requested a review from a team as a code owner September 13, 2024 19:33
francinelucca
francinelucca approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

patrickhlauke
patrickhlauke requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a tiny suggestion to use backticks, looking good to me

content/components/pagehead.mdx Outdated Show resolved Hide resolved
@TylerJDev TylerJDev merged commit fd92bd6 into main Sep 17, 2024
6 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-more-a11y-notes branch September 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerJDev @patrickhlauke @francinelucca