Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magic methods detection #2228

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix magic methods detection #2228

merged 2 commits into from
Aug 28, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 28, 2023

Input:

<?php
class Foo
{
    public function __pRoTo__() {}
    public function cOnStRuCtOr() {}
}

Output:

<?php
class Foo
{
    public function Have not implemented kind undefined yet.()
    {
    }
    public function Have not implemented kind undefined yet.()
    {
    }
}

@fisker fisker marked this pull request as draft August 28, 2023 03:15
@fisker fisker marked this pull request as ready for review August 28, 2023 03:19
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 IIRC, there is an open issue about this somewhere in our issue tracker 🙃

@czosel czosel merged commit 063209f into prettier:main Aug 28, 2023
12 checks passed
@fisker fisker deleted the magic-methods branch August 28, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants