Replace AsyncHttpClient with Ember #121
Conversation
| : F[A] = | ||
| Async.fromFuture(F.delay(mono.asScala.toFuture)) | ||
| def monoToAsync[F[_]: ConcurrentEffect, A](mono: Mono[A]): F[A] = | ||
| fromPublisher[F, A](mono).compile.lastOrError |
There was a problem hiding this comment.
This is probably the most significant change. We used to use this to convert, but it looks obsolete given that Scala has supported Java lambdas since 2016. It was also bringing in ancient versions of reactor-netty (the source of this stack trace)
This appeared to be the most straightforward way to convert Monos to IO, given Monos are also publishers.
| @@ -23,7 +23,7 @@ ThisBuild / githubWorkflowBuildPreamble += | |||
| List("decryptSecret gcs/src/test/resources/bad-auth-file.json.enc"), | |||
| name = Some("Decrypt bad gcp service account json key")) | |||
|
|
|||
| val AwsSdkVersion = "2.15.34" | |||
| val AwsSdkVersion = "2.16.21" | |||
There was a problem hiding this comment.
This needs to be bumped because of netty version change, right? Needs to be done in other libs using the aws sdk as well.
And I think something similar needs to happen for azure as well because they also use netty.
It can be quite a pain to get all of the netty versions line up across all libs. Depending on how far we are with this, it may be easier to roll back https://github.com/precog/quasar-datasource-url/pull/763 et al and publish our own fix directly on top of http4s 0.21.25 so that nothing related to netty changes.
There was a problem hiding this comment.
Yeah, we came to the same conclusion and are giving that a go.
No description provided.