Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix maxp table" #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoshoku
Copy link

@yoshoku yoshoku commented Apr 23, 2024

With ttfunk v1.8.0, using Japanese true type fonts such as GenShin Gothic resulted in creating PDF files that could not be loaded in Acrobat Reader. The cause seems to be with maxp, and by applying a monkey patch to make the code equivalent to ttfunk v1.7.0, normal PDFs were able to be generated. So I would like to revert the relevant code. If I revert the pull request #78, the ChangeLog and others would also be reverted, so I reverted only the code to be the same as ttfunk v1.7.0. Issue #102 likely has the same root cause.

Copy link

@nilsrennebarth nilsrennebarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the Adobe Reader warnings "Cannot extract embedded font xxx" when viewing a PDF generated with prawn 2.4.0
I am well aware that reverting this change to the encode function is not a real fix, but the current encode function just does not work so we better get back to the old function that does work.

@hayaokimura
Copy link

hayaokimura commented Oct 22, 2024

Thank you for developing such a wonderful gem.

Is there any issue preventing this PR from being merged? I’m experiencing the same issue in my environment, and I would love to update the TTFunk version if this could be merged. It would be greatly appreciated.

@pointlessone
Copy link
Member

@hayaokimura Lack of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants