data model changes to add name, id and dependency for sr annotaiton #5
Conversation
| @@ -68,6 +77,16 @@ public void accept(List<Span> spans) { | |||
| } | |||
| String res = gson.toJson(jsonElement); | |||
| String msg = "{ \"Span\":" + res + "}"; | |||
| //data model changes | |||
| telemetry.getContext().getOperation().setId(traceId); | |||
| telemetry.getContext().getOperation().setName(span.name); | |||
There was a problem hiding this comment.
span.name should got to dependency.name or request.name. Setting it on operation context is optional
|
|
||
| for (Annotation annotation : span.annotations) { | ||
| if (annotation.value.equalsIgnoreCase(Constants.SERVER_RECV)) { | ||
| telemetry.trackDependency(Constants.SERVER_RECV, "request", new Duration(span.duration==null?0L:span.duration), |
There was a problem hiding this comment.
SERVER_RECV means server received? When server receives - you need to track request. Dependency is when client send outgoing request.
|
|
||
| String spanId = Long.toString(span.id); | ||
| String traceId = Long.toString(span.traceId); | ||
| String traceIdHigh = Long.toString(span.traceIdHigh); |
There was a problem hiding this comment.
is there parent ID? Can you please place it into custom property for now.
| import com.microsoft.applicationinsights.telemetry.SeverityLevel; | ||
| import com.microsoft.applicationinsights.TelemetryConfiguration; | ||
| import com.microsoft.applicationinsights.telemetry.Duration; | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
oh, something went wrong here
|
Hi @SergeyKanzhelev, Added request on SS annotation and parentid to customprops. Please review. |
| for (Annotation annotation : span.annotations) { | ||
|
|
||
| if (annotation.value.equalsIgnoreCase(Constants.CLIENT_SEND)) { | ||
| String spanName = span.name !=null && !span.name.isEmpty()?span.name:Constants.CLIENT_SEND; |
There was a problem hiding this comment.
does span in Zipkin has special annotation for an error? In Application Insights we rely on failure flag for many scenarios. So if we can deduct that span failed from annotations - it will improve those scenarios.
There was a problem hiding this comment.
Yes, they suggest logging a binary annotation and have an open issue. We shall discuss further how we set AI flag.
| @@ -68,6 +85,24 @@ public void accept(List<Span> spans) { | |||
| } | |||
| String res = gson.toJson(jsonElement); | |||
| String msg = "{ \"Span\":" + res + "}"; | |||
| //data model changes | |||
| telemetry.getContext().getOperation().setId(traceId); | |||
There was a problem hiding this comment.
I think it should be a combination of two ids - traceIdHigh and traceId
There was a problem hiding this comment.
Yes, Shall I concatenate both strings while setting id? How are we going to retrieve back?
@SergeyKanzhelev please verify the changes.