Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for 'Dracut' #1439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gl00ria
Copy link
Contributor

@Gl00ria Gl00ria commented May 4, 2024

Pull Request

Description

EndeavourOS & some other Linux distibutions using 'Dracut' as the 'initramfs image' generator inested of 'mkinitcpio', this commit should handle the case of using either (mkinitcpio OR dracut)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected on (Vanilla Arch & EndeavourOS)
  • All new and existing tests passed.

Screenshots

N/A

Additional context

N/A

EndeavourOS & some other Linux distibutions using 'Dracut' as the
'initramfs image' generator inested of 'mkinitcpio', this commit should
handle the case of using either (mkinitcpio OR dracut)
@rubiin
Copy link
Contributor

rubiin commented May 5, 2024

Looks good so far, LGTM

@rubiin
Copy link
Contributor

rubiin commented Aug 11, 2024

@kRHYME7 this can be merged

Copy link
Contributor

@dieBakterie dieBakterie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the hyprland wiki it stands to add options nvidia-drm modeset=1 fbdev=1

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 12, 2024

I can't test it. But can we get a solid reference if fbdev set to 1 is really required and will not cause issues outside Hyprland, eg. other DE. I saw it in the wiki but maybe it's only for specific things. Thanks!

@dieBakterie
Copy link
Contributor

dieBakterie commented Aug 13, 2024

I can't test it. But can we get a solid reference if fbdev set to 1 is really required and will not cause issues outside Hyprland, eg. other DE. I saw it in the wiki but maybe it's only for specific things. Thanks!

On arch it says to 'cause problems and an post on reddit(5 months ago so could be old) seems it like this disables tty so hmm and should only be set when using 550 or newer driver as stated here i guess? needed when using simple-drm as stated here in arch. Had no issues with it but i also use the experimental direct backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants