Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[waybar] Capability to have user modules by adding "#tag" #1418

Closed
wants to merge 1 commit into from
Closed

[waybar] Capability to have user modules by adding "#tag" #1418

wants to merge 1 commit into from

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented Apr 30, 2024 •
edited
Loading

Pull Request

Ability #1337 to add hyprland/workspaces#kanji

image

image

  • atomic change, I hope this does not borke ,

@kRHYME7 kRHYME7 marked this pull request as ready for review April 30, 2024 16:49
@kRHYME7 kRHYME7 mentioned this pull request Apr 30, 2024
Open
@kRHYME7 kRHYME7 requested review from T-Crypt and Skerse and removed request for T-Crypt May 13, 2024 17:19
@abenezerw
Copy link
Contributor

Ohhh yes smart implementation, the kanji workspaces work so yeah this works.

@rubiin rubiin mentioned this pull request Jul 3, 2024
Closed
16 tasks
@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Jul 23, 2024

Needs more test please.

@kRHYME7 kRHYME7 changed the title Capability to copy other modules with #userprefs [waybar] Capability to have user modules by adding "#tag" Jul 27, 2024
@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Jul 27, 2024

@rubiin Can you help me merge this one? Open a new PR then I'll merge

@rubiin
Copy link
Contributor

rubiin commented Jul 28, 2024

ok

@rubiin rubiin mentioned this pull request Jul 28, 2024
Merged
16 tasks
@kRHYME7 kRHYME7 closed this Jul 28, 2024
@kRHYME7 kRHYME7 deleted the Custom_waybar_modules branch August 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@Enigma1309 Enigma1309 Enigma1309 approved these changes

@prasanthrangan prasanthrangan Awaiting requested review from prasanthrangan

@Skerse Skerse Awaiting requested review from Skerse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kRHYME7 @abenezerw @rubiin @Enigma1309