Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to make cache more useful for PR builds. #1959

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Attempt to make cache more useful for PR builds. #1959

merged 1 commit into from
Oct 25, 2024

Conversation

lvella
Copy link
Member

@lvella lvella commented Oct 25, 2024 •
edited
Loading

The same build steps is now performed in both cache build and PR build.

@lvella
Copy link
Member Author

lvella commented Oct 25, 2024

We will only know if it worked after merging.

pacheco
pacheco approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@pacheco pacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fingers crossed

@leonardoalt leonardoalt added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit fe3a4f0 Oct 25, 2024
14 checks passed
@leonardoalt leonardoalt deleted the useful-cache branch October 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacheco pacheco pacheco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvella @pacheco @leonardoalt