Properly re-print trait impls. #1956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
re-print-trait-impls
branch
from
4cd4e27
to
5594ab5
Compare
gzanitti
reviewed
Oct 25, 2024
| } | ||
| let Some(trait_impls) = self.trait_impls.get(trait_decl_name) else { | ||
| return Err(format!( | ||
| "Could not find an implementation for the trait function {reference}" |
There was a problem hiding this comment.
maybe
Suggested change
| "Could not find an implementation for the trait function {reference}" | |
| "Could not find an implementation for the trait declaration {trait_decl_name}" |
to differentiate it from the following error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the list of trait implementations was not present in Analyzed, but we need them for re-printing the PIL (and other things).
This PR also contains a simplification in that it only keeps a list of all trait impls, not sorted into which trait they implement. This information is only relevant during trait impl solving, where we re-build that data structure. Keeping the pre-sorted layout would make re-printing in source order much more difficult.
And now it also formats paths to the current namespace properly.