Fix small continuations issue #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacheco
reviewed
Oct 24, 2024
| *register_memory_snapshot.get(&(id as u32)).unwrap() | ||
| *register_memory_snapshot | ||
| .get(&(id as u32)) | ||
| .unwrap_or(&0.into()) |
There was a problem hiding this comment.
this is fine i think, but i wonder is the executor itself should take care of this (zero out unused registers)
There was a problem hiding this comment.
for that it would have to know which registers we're using
pacheco
approved these changes
Oct 24, 2024
| *register_memory_snapshot.get(&(id as u32)).unwrap() | ||
| *register_memory_snapshot | ||
| .get(&(id as u32)) | ||
| .unwrap_or(&0.into()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this unwrapping a None when using continuations with a very low max degree. It's kinda hard to trigger without triggering a bunch of other issues, but I think this fix is enough for now: if a register is never used it is not contained in the snapshot, so it should be 0.