Use lower max degree by default and let user change it #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacheco
reviewed
Oct 24, 2024
|
what's the usage for the user setting the MIN_DEGREE? |
not much, that's why I didn't expose it to the end user |
|
updated, waiting for the other PR to be merged |
|
this is ready now |
pacheco
approved these changes
Oct 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Since RUST_LOG=info is quite verbose, I think we should have a few messages that are always shown to the user. The main point is to give some results about what they asked (run/proof), but also let them know when a heavier process is going on. I ran this locally and felt the messages and flow were ok. Depends on #1948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1946