Plonky3 keccak memory #1832
Open
Plonky3 keccak memory #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w, but still won't work due to not enough auto witgen passes for memory read and write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ready for review as tests all pass. Methodology documented as comments in the
keccak16_memory.asmfile.I have only one optimization in mind, but I'm not sure if it'd speed things up, which will depend on more backend knowledge. Specifically, currently I'm using permutation links to
add_subsubmachine to calculate memory addresses for the input and output (basically adding 4 to the address for each read/write). Theadd_subsubmachine itself is pretty compact and efficient in that it doesn't contain any wasted columns. However, I could instead create regular constraints in the main machine to enforce the add 4 logic. Because currently the address columns are only used in the first and last rows, I can put the carry bit in the second and the second to last rows of these address columns. I'll also need to create byte2 checks for all the calculated input/output addresses, which is currently done in theadd_subsubmachine.The key question remains to be answered is whether it's cheaper to do many permutation links or to move everything to "native" constraint in the main machine. The actual number of constraints will be similar in either cases, it's just where we do them.
Either way we go, I think we should approve this PR as is first, because it's currently functioning and is ready for benchmarking. Any optimization mentioned I can do it in another PR.