make starky optional (#1951)

Currently the users end up always compiling starky as well. This removes
that.

I think the CI tests should not change here because we run it with
`--all-features`.

I also made p3 default in the cli and cli-rs crates.

backend/Cargo.toml

@@ -15,8 +15,14 @@ halo2 = [
   "dep:snark-verifier",
   "dep:halo2_solidity_verifier",
 ]
+estark-starky = ["dep:starky"]
 estark-polygon = ["dep:pil-stark-prover"]
-plonky3 = ["dep:powdr-plonky3", "dep:p3-commit", "dep:p3-matrix", "dep:p3-uni-stark"]
+plonky3 = [
+  "dep:powdr-plonky3",
+  "dep:p3-commit",
+  "dep:p3-matrix",
+  "dep:p3-uni-stark",
+]
 stwo = ["dep:stwo-prover"]
 
 # Enable AVX or Neon accordingly in backends that support them.
@@ -35,25 +41,29 @@ powdr-backend-utils.workspace = true
 
 powdr-plonky3 = { path = "../plonky3", optional = true }
 
-starky = { git = "https://github.com/0xEigenLabs/eigen-zkvm.git", rev = "cf405b2e2cecb8567cfd083a55936b71722276d5" }
+starky = { git = "https://github.com/0xEigenLabs/eigen-zkvm.git", rev = "cf405b2e2cecb8567cfd083a55936b71722276d5", optional = true }
 pil-stark-prover = { git = "https://github.com/powdr-labs/pil-stark-prover.git", rev = "769b1153f3ae2d7cbab4c8acf33865ed13f8a823", optional = true }
 
 # TODO change this once Halo2 releases 0.3.1
 #halo2_proofs = { git = "https://github.com/privacy-scaling-explorations/halo2", tag = "v0.3.0", features = ["circuit-params"] }
-halo2_proofs = { git = "https://github.com/powdr-labs/halo2.git", rev = "fb8087565115ff38da4074b9d1777e9a97222caa", features = ["circuit-params"], optional = true }
-halo2_curves = { version = "0.6.1", package = "halo2curves", optional = true}
+halo2_proofs = { git = "https://github.com/powdr-labs/halo2.git", rev = "fb8087565115ff38da4074b9d1777e9a97222caa", features = [
+  "circuit-params",
+], optional = true }
+halo2_curves = { version = "0.6.1", package = "halo2curves", optional = true }
 # TODO change this once Halo2 releases 0.3.1 and snark-verifier uses it
 #snark-verifier = { git = "https://github.com/privacy-scaling-explorations/snark-verifier", tag = "v2024_01_31" }
 snark-verifier = { git = "https://github.com/powdr-labs/snark-verifier.git", rev = "55012261fd4b0b8d21b581a9782d05258afe4104", optional = true }
-halo2_solidity_verifier = { git = "https://github.com/powdr-labs/halo2-solidity-verifier.git", rev = "ecae7fd2f62178c18b5fe18011630aa71da3371f", features = ["evm"], optional = true }
+halo2_solidity_verifier = { git = "https://github.com/powdr-labs/halo2-solidity-verifier.git", rev = "ecae7fd2f62178c18b5fe18011630aa71da3371f", features = [
+  "evm",
+], optional = true }
 
 p3-commit = { git = "https://github.com/plonky3/Plonky3.git", rev = "2192432ddf28e7359dd2c577447886463e6124f0", features = [
-    "test-utils",
+  "test-utils",
 ], optional = true }
-p3-matrix = { git = "https://github.com/plonky3/Plonky3.git", rev = "2192432ddf28e7359dd2c577447886463e6124f0", optional = true } 
-p3-uni-stark = { git = "https://github.com/plonky3/Plonky3.git", rev = "2192432ddf28e7359dd2c577447886463e6124f0", optional = true } 
+p3-matrix = { git = "https://github.com/plonky3/Plonky3.git", rev = "2192432ddf28e7359dd2c577447886463e6124f0", optional = true }
+p3-uni-stark = { git = "https://github.com/plonky3/Plonky3.git", rev = "2192432ddf28e7359dd2c577447886463e6124f0", optional = true }
 # TODO: Change this to main branch when the `andrew/dev/update-toolchain` branch is merged,the main branch is using "nightly-2024-01-04", not compatiable with plonky3
-stwo-prover = { git= "https://github.com/starkware-libs/stwo.git",optional=true, rev="52d050c18b5dbc74af40214b3b441a6f60a20d41" }
+stwo-prover = { git = "https://github.com/starkware-libs/stwo.git", optional = true, rev = "52d050c18b5dbc74af40214b3b441a6f60a20d41" }
 
 strum = { version = "0.24.1", features = ["derive"] }
 log = "0.4.17"

backend/src/lib.rs

@@ -1,14 +1,16 @@
 #![deny(clippy::print_stdout)]
 
+#[cfg(feature = "estark-starky")]
 mod estark;
 #[cfg(feature = "halo2")]
 mod halo2;
 #[cfg(feature = "plonky3")]
 mod plonky3;
+#[cfg(feature = "stwo")]
+mod stwo;
 
 mod composite;
 mod field_filter;
-mod stwo;
 
 use powdr_ast::analyzed::Analyzed;
 use powdr_executor::{constant_evaluator::VariablySizedColumn, witgen::WitgenCallback};
@@ -36,12 +38,16 @@ pub enum BackendType {
     #[cfg(feature = "estark-polygon")]
     #[strum(serialize = "estark-polygon-composite")]
     EStarkPolygonComposite,
+    #[cfg(feature = "estark-starky")]
     #[strum(serialize = "estark-starky")]
     EStarkStarky,
+    #[cfg(feature = "estark-starky")]
     #[strum(serialize = "estark-starky-composite")]
     EStarkStarkyComposite,
+    #[cfg(feature = "estark-starky")]
     #[strum(serialize = "estark-dump")]
     EStarkDump,
+    #[cfg(feature = "estark-starky")]
     #[strum(serialize = "estark-dump-composite")]
     EStarkDumpComposite,
     #[cfg(feature = "plonky3")]
@@ -78,18 +84,31 @@ impl BackendType {
             BackendType::EStarkPolygonComposite => Box::new(
                 composite::CompositeBackendFactory::new(estark::polygon_wrapper::Factory),
             ),
+            #[cfg(feature = "estark-starky")]
             BackendType::EStarkStarky => Box::new(estark::starky_wrapper::Factory),
+            #[cfg(feature = "estark-starky")]
             BackendType::EStarkStarkyComposite => Box::new(
                 composite::CompositeBackendFactory::new(estark::starky_wrapper::Factory),
             ),
+            // We need starky here because the dump backend uses some types that come from starky.
+            #[cfg(feature = "estark-starky")]
             BackendType::EStarkDump => Box::new(estark::DumpFactory),
+            #[cfg(feature = "estark-starky")]
             BackendType::EStarkDumpComposite => {
                 Box::new(composite::CompositeBackendFactory::new(estark::DumpFactory))
             }
             #[cfg(feature = "plonky3")]
             BackendType::Plonky3 => Box::new(plonky3::Factory),
             #[cfg(feature = "stwo")]
             BackendType::Stwo => Box::new(stwo::StwoProverFactory),
+            #[cfg(not(any(
+                feature = "halo2",
+                feature = "estark-polygon",
+                feature = "estark-starky",
+                feature = "plonky3",
+                feature = "stwo"
+            )))]
+            _ => panic!("Empty backend."),
         }
     }
 }

cli-rs/Cargo.toml

@@ -8,9 +8,10 @@ homepage = { workspace = true }
 repository = { workspace = true }
 
 [features]
-default = []
+default = ["plonky3"]
 halo2 = ["powdr-pipeline/halo2"]
 plonky3 = ["powdr-pipeline/plonky3"]
+estark-starky = ["powdr-pipeline/estark-starky"]
 estark-polygon = ["powdr-pipeline/estark-polygon", "powdr-riscv/estark-polygon"]
 
 [dependencies]

cli/Cargo.toml

@@ -9,14 +9,15 @@ repository = { workspace = true }
 default-run = "powdr"
 
 [features]
-default = [] # halo2 is disabled by default
+default = ["plonky3"]
 halo2 = ["powdr-backend/halo2", "powdr-pipeline/halo2"]
 plonky3 = ["powdr-backend/plonky3", "powdr-pipeline/plonky3"]
+estark-starky = ["powdr-backend/estark-starky", "powdr-pipeline/estark-starky"]
 estark-polygon = [
   "powdr-backend/estark-polygon",
   "powdr-pipeline/estark-polygon",
 ]
-stwo=["powdr-backend/stwo","powdr-pipeline/stwo"]
+stwo = ["powdr-backend/stwo", "powdr-pipeline/stwo"]
 
 simd = ["powdr-backend/simd", "powdr-pipeline/simd"]
 
@@ -37,6 +38,8 @@ tracing-subscriber = { version = "0.3.17", features = ["std", "env-filter"] }
 tracing-forest = { version = "0.1.6", features = ["ansi", "smallvec"] }
 
 [dev-dependencies]
+powdr-pipeline = { workspace = true, features = ["estark-starky"] }
+
 tempfile = "3.6"
 
 test-log = "0.2.12"

pipeline/Cargo.toml

@@ -8,9 +8,10 @@ homepage = { workspace = true }
 repository = { workspace = true }
 
 [features]
-default = []                                      # halo2 is disabled by default
+default = []
 halo2 = ["powdr-backend/halo2"]
 plonky3 = ["powdr-backend/plonky3"]
+estark-starky = ["powdr-backend/estark-starky"]
 estark-polygon = ["powdr-backend/estark-polygon"]
 stwo = ["powdr-backend/stwo"]
 

pipeline/src/test_util.rs

@@ -5,13 +5,17 @@ use powdr_number::{
     KoalaBearField,
 };
 use powdr_pil_analyzer::evaluator::{self, SymbolLookup};
+use std::env;
 use std::path::PathBuf;
-use std::{env, fs};
 
 use std::sync::Arc;
 
 use crate::pipeline::Pipeline;
+
+#[cfg(feature = "estark-starky")]
 use crate::verify::verify;
+#[cfg(feature = "estark-starky")]
+use std::fs;
 
 pub fn resolve_test_file(file_name: &str) -> PathBuf {
     PathBuf::from(format!("../test_data/{file_name}"))
@@ -102,6 +106,15 @@ pub fn asm_string_to_pil<T: FieldElement>(contents: &str) -> Arc<Analyzed<T>> {
         .unwrap()
 }
 
+#[cfg(not(feature = "estark-starky"))]
+pub fn run_pilcom_with_backend_variant(
+    _pipeline: Pipeline<GoldilocksField>,
+    _backend_variant: BackendVariant,
+) -> Result<(), String> {
+    Ok(())
+}
+
+#[cfg(feature = "estark-starky")]
 pub fn run_pilcom_with_backend_variant(
     pipeline: Pipeline<GoldilocksField>,
     backend_variant: BackendVariant,
@@ -153,6 +166,14 @@ pub fn gen_estark_proof(pipeline: Pipeline<GoldilocksField>) {
     }
 }
 
+#[cfg(not(feature = "estark-starky"))]
+pub fn gen_estark_proof_with_backend_variant(
+    _pipeline: Pipeline<GoldilocksField>,
+    _backend_variant: BackendVariant,
+) {
+}
+
+#[cfg(feature = "estark-starky")]
 pub fn gen_estark_proof_with_backend_variant(
     pipeline: Pipeline<GoldilocksField>,
     backend_variant: BackendVariant,
@@ -438,6 +459,14 @@ pub fn assert_proofs_fail_for_invalid_witnesses_pilcom(
     assert!(run_pilcom_with_backend_variant(pipeline, BackendVariant::Composite).is_err());
 }
 
+#[cfg(not(feature = "estark-starky"))]
+pub fn assert_proofs_fail_for_invalid_witnesses_estark(
+    _file_name: &str,
+    _witness: &[(String, Vec<u64>)],
+) {
+}
+
+#[cfg(feature = "estark-starky")]
 pub fn assert_proofs_fail_for_invalid_witnesses_estark(
     file_name: &str,
     witness: &[(String, Vec<u64>)],

pipeline/tests/asm.rs

@@ -334,6 +334,7 @@ fn pil_at_module_level() {
     regular_test(f, Default::default());
 }
 
+#[cfg(feature = "estark-starky")]
 #[test]
 fn read_poly_files() {
     let asm_files = ["asm/vm_to_block_unique_interface.asm", "asm/empty.asm"];

pipeline/tests/powdr_std.rs

@@ -105,6 +105,7 @@ fn arith_large_test() {
     // Running gen_estark_proof(f, Default::default())
     // is too slow for the PR tests. This will only create a single
     // eStark proof instead of 3.
+    #[cfg(feature = "estark-starky")]
     pipeline
         .with_backend(powdr_backend::BackendType::EStarkStarky, None)
         .compute_proof()