Fix loading react, react-dom, and react-dom/client.js for unit tests #5238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes how
react
,react-dom
, andreact-dom/client.js
are loaded in unit tests. This fixes the unit test hang that was seen as a result of #5181.QA Notes
yarn test-browser-no-install --browser chromium
is now working again. If you run:yarn test-browser-no-install --browser chromium --debug
You will see new output that shows how we are loading
react-dom/client.js
:This work also fixes the long-standing warnings that were happening when loading the
notebookServiceImpl.test
module: