-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connections list screen #5153
Open
dfalbel
wants to merge
32
commits into
main
Choose a base branch
from
feature/connections-list-screen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,383
−1,011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
changed the title
Move schema navigation to a separate component
Implement connections list screen
Oct 24, 2024
This allows fixing a bug causing the 'refresh' button to discard the expand state.
Let's wait until we branch for 2024.11, and once main is open for prerelease 2024.12 changes we can review and plan to merging this on main (likely tomorrow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #5107.
Demo usage:
Screen.Recording.2024-10-30.at.12.57.59.mov
TODO:
onChangeConnections
event when their status changes.List
component - so it scrolls correctly in the presence of multiple connections.%connection_view conn
should direct to schema explorer viewFollow up PR: